fix: 1.21.9 and 1.21.11 adapters throw invalid bit count when calling unpack

[MrJoshuaT]

Overview

Pasting clipboards in some chunks throw a validation error when calling "unpack":

[21:26:34 ERROR]: [com.fastasyncworldedit.bukkit.adapter.AbstractBukkitGetBlocks] Error performing chunk call at chunk -764,798
java.lang.RuntimeException: Failed to create block palette
        at FastAsyncWorldEdit-Paper-2.15.0.jar/com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_21_9.PaperweightPlatformAdapter.newChunkSection(PaperweightPlatformAdapter.java:493) ~[FastAsyncWorldEdit-Paper-2.15.0.jar:?]
        at FastAsyncWorldEdit-Paper-2.15.0.jar/com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_21_9.PaperweightGetBlocks.internalCall(PaperweightGetBlocks.java:549) ~[FastAsyncWorldEdit-Paper-2.15.0.jar:?]
        at FastAsyncWorldEdit-Paper-2.15.0.jar/com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_21_9.PaperweightGetBlocks.internalCall(PaperweightGetBlocks.java:96) ~[FastAsyncWorldEdit-Paper-2.15.0.jar:?]
        at FastAsyncWorldEdit-Paper-2.15.0.jar/com.fastasyncworldedit.bukkit.adapter.AbstractBukkitGetBlocks.tryInternalCall(AbstractBukkitGetBlocks.java:135) ~[FastAsyncWorldEdit-Paper-2.15.0.jar:?]
        at FastAsyncWorldEdit-Paper-2.15.0.jar/com.fastasyncworldedit.bukkit.adapter.AbstractBukkitGetBlocks.call(AbstractBukkitGetBlocks.java:92) ~[FastAsyncWorldEdit-Paper-2.15.0.jar:?]
        at FastAsyncWorldEdit-Paper-2.15.0.jar/com.fastasyncworldedit.core.queue.implementation.chunk.ChunkHolder.call(ChunkHolder.java:1090) ~[FastAsyncWorldEdit-Paper-2.15.0.jar:?]
        at FastAsyncWorldEdit-Paper-2.15.0.jar/com.fastasyncworldedit.core.queue.implementation.chunk.ChunkHolder.call(ChunkHolder.java:1052) ~[FastAsyncWorldEdit-Paper-2.15.0.jar:?]
        at FastAsyncWorldEdit-Paper-2.15.0.jar/com.fastasyncworldedit.core.queue.implementation.chunk.ChunkHolder.call(ChunkHolder.java:37) ~[FastAsyncWorldEdit-Paper-2.15.0.jar:?]
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) ~[?:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: java.lang.IllegalStateException: Invalid bit count, calculated 0, but container declared 15
        at com.mojang.serialization.DataResult$Error.getOrThrow(DataResult.java:287) ~[datafixerupper-8.0.16.jar:?]
        at com.mojang.serialization.DataResult.getOrThrow(DataResult.java:81) ~[datafixerupper-8.0.16.jar:?]
        at FastAsyncWorldEdit-Paper-2.15.0.jar/com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_21_9.PaperweightPlatformAdapter.newChunkSection(PaperweightPlatformAdapter.java:491) ~[FastAsyncWorldEdit-Paper-2.15.0.jar:?]
        ... 11 more

Description

On the Bakery network we had someone find an issue where specific chunks cannot be pasted into, in this case chunk -764,798 (but there were others, i.e -769 798), and it throws the error above. Restarts does not fix it, but it happened after updating to 1.21.10. All our servers are all on 1.21.10, we saw this same error when using FAWE FastAsyncWorldEdit-Paper-2.14.1-SNAPSHOT-1197.jar which used the v1_21_9 adapter, and when using FastAsyncWorldEdit-Paper-2.15.0.jar which used the v1_21_11 adapter.

Tried various approaches to fix unpack():

• Populate palette with actual blocks -> "calculated 9, but declared 15" (290 blocks = 9 bits, not 15)
• Don't adjust bitsPerEntry -> "Missing Palette entry for index 311" (bit data has registry ID 311, palette only has indices 0-289)
• Use deprecated constructor (like 1.21.6) -> API removed in 1.21.9+

So the solution proposed here is to replace the PalettedContainer.unpack() call with manual population, which does require 4096 individual set calls instead of bulk palette creation.

I am not sure if this is the correct change to make or not. I've tested extensively and it fixes the error mentioned above.

Submitter Checklist

• Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
• Ensure that the pull request title represents the desired changelog entry.
• New public fields and methods are annotated with @since TODO.
• I read and followed the contribution guidelines.

[dordsor21]

I think we can just set bitsPerEntry to -1?

[dordsor21]

Okay so the root of the issue is that we seem to now need to provide the list of all block states, otherwise it simply doesn't accept it needs the global palette...