fix: sponge v3 palette writer with __reserved__#3295
fix: sponge v3 palette writer with __reserved__#3295PierreSchwang wants to merge 1 commit intomainfrom
Conversation
9872a5d to
ec7cb33
Compare
|
What exactly is the fix? The change is a little abstract aha |
|
Uhm, it was something related to an issue reported on discord. When saving a clipboard with some (maybe specific) mask, the writer would add a minecraft:reserved block state into the palette iirc. I think this fix kinda streamlines it with the FastV2Writer? I'll have to look into it again lol. But this should write reserved as air for some reason (I guess because the state cache is setup that way or something) |
|
I replace the ordinal in the resolver function if it's reserved, but don't use the ordinal to retrieve the string representation. I guess updating / replacing the actually BlockStateHolder could be cleaner? |
|
Yeah we shouldn't have |
Overview
Fixes an issue where reserved was written into the block palette for sponge v3 schematics (example would be masked copies).
Submitter Checklist
@since TODO.