Fixes bugs with copy entities from Position A to Position B

[TheMeinerLP]

Overview

Fixes #2140
Fixes #2427

Description

This PR included the fix for passenger of entities and also leashs for other entities.
That means now //copy -e and //paste -e will work to 99% correct now for entities except some edge cases.

Submitter Checklist

• Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
• Ensure that the pull request title represents the desired changelog entry.
• New public fields and methods are annotated with @since TODO.
• I read and followed the contribution guidelines.

[TheMeinerLP]

I tested each of them on a Plot world

[LedariaTim1]

i just compiled your bugfix and tested it, the entities including passanger are now copied, but they are now both independent entities and no longer mounted. in my case the pig is no longer sitting on the invisible armorstand and can be moved around

[TheMeinerLP]

Bump!
Tested with 1.20.1

[seercle]

Hey, do we have any news about this? This fix would be very useful for builders who use Block Display Studio to create structures.

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[TehManu]

Hey, this solution does not work with vehicles because the passengers missing their NBT data. I'm not sure but i think the real problem is here.

The method only saves NBT data when the entity is not a passenger

Maybe i might be wrong, but i tested it with saveWithoutId() and it worked with copying the passengers and they also had their correct nbt data being applied.

[TheMeinerLP]

Hey, this solution does not work with vehicles because the passengers missing their NBT data. I'm not sure but i think the real problem is here.

The method only saves NBT data when the entity is not a passenger

Maybe i might be wrong, but i tested it with saveWithoutId() and it worked with copying the passengers and they also had their correct nbt data being applied.

Thanks for reporting this. I will take a look

[TehManu]

I found another way to also get the same result in the PaperweightGetBlocks class, replace the code after line 672 with the following one.

[TehManu]

Hi, are there any updates on this? Our players are waiting for a fix. @TheMeinerLP

[TheMeinerLP]

Hi, are there any updates on this? Our players are waiting for a fix. @TheMeinerLP

Sorry, I was on sick leave, and I am not yet 100% recovered

[Mrpressed]

Thank you for working on this, ive been waiting for a fix.

[TehManu]

Sorry, I was on sick leave, and I am not yet 100% recovered

Thank you for your work, get well soon! Could you please take a look at the nbt data issue when copying passengers? I would really appreciate if you could fix this too.

[Mrpressed]

Fixing the NBT issue would be amazing, it's what's holding back the development of my server currently.

[kylelaverty]

Sorry, I was on sick leave, and I am not yet 100% recovered

Thank you for working on this.

[TehManu]

Hi @TheMeinerLP, any updates on this? It's a while since there was any progress on this.

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!