Use wrappers to complete SciPy and NumPy interface namespaces#226
Merged
ndgrigorian merged 3 commits intomasterfrom Sep 26, 2025
Merged
Use wrappers to complete SciPy and NumPy interface namespaces#226ndgrigorian merged 3 commits intomasterfrom
ndgrigorian merged 3 commits intomasterfrom
Conversation
…importing directly avoids circular dependencies under certain conditions
antonwolfy
approved these changes
Sep 25, 2025
Collaborator
antonwolfy
left a comment
There was a problem hiding this comment.
The fix LGTM! But need to add the PR to the changelog also.
Collaborator
Author
done |
Collaborator
|
Will a change like this always require scipy as a mkl_fft dependency, or can it still be optional? |
Collaborator
Author
It can still be optional—since the scipy interface is only exposed in alternatively, the import could be made lazy, so we could do |
ekomarova
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes using wrappers for
fftfreq,fftshift,ifftshift, andrfftfreqinstead of importing them fromscipy.fftornumpy.fftdirectlyThese thin wrappers can avoid infinite recursion of dependencies, i.e., when importing Intel NumPy with Intel SciPy in the environment