Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the SciPy FFT interface optional by only importing scipy_fft when SciPy is installed, and adapts packaging, tests, and documentation accordingly.
- Introduce a new optional dependency group for SciPy in
pyproject.tomland update test requirements. - Conditionally import
scipy_fftin the interface module. - Modify tests to skip SciPy‐related tests when SciPy is absent and unify version checks.
- Update conda recipes and README to reflect the optional SciPy dependency.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added scipy_interface extras, tightened test group to SciPy ≥1.10 |
| mkl_fft/interfaces/init.py | Wrapped SciPy FFT import in a try/except |
| mkl_fft/tests/third_party/scipy/*.py | Added module-level skips, replaced hard imports and version checks |
| mkl_fft/tests/test_interfaces.py | Dynamic interface list and pytest.importorskip for SciPy tests |
| conda-recipe/meta.yaml | Updated SciPy test requirement to ≥1.10 |
| conda-recipe-cf/meta.yaml | Updated SciPy test requirement to ≥1.10 |
| README.md | Added optional SciPy install steps |
Comments suppressed due to low confidence (3)
conda-recipe/meta.yaml:36
- Conda tests require SciPy >=1.10, but
test_basic.pyskips <1.12; update this toscipy >=1.12for consistency.
- - scipy >=1.10
conda-recipe-cf/meta.yaml:35
- Conda-CF tests require SciPy >=1.10, but other tests skip <1.12; consider bumping to
scipy >=1.12.
- - scipy >=1.10
README.md:96
- [nitpick] The README suggests installing SciPy without a version; consider specifying
pip install scipy>=1.12to match test requirements.
- - `pip install scipy` (optional: for using `mkl_fft.interface.scipy_fft` module)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR,
mkl_fft.interfaceis modified to only importscipy_fftifscipyis installed.