Conversation
7948c2e to
196b67e
Compare
mkl_fft package when running test on linux in CI
mkl_fft package when running test on linux in CImkl_fft package when running test on Linux in CI
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that tests on Linux in CI install the mkl_fft package from the local channel and pins the mkl-devel dependency correctly for Python 3.9 and 3.10.
- Pins mkl-devel version to 2024.2.* for Python 3.9 and 3.10 in meta.yaml.
- Adds steps in the conda workflow to test the local channel and extract the package version for installation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| conda-recipe/meta.yaml | Added a conditional dependency line to pin mkl-devel for specific Python versions. |
| .github/workflows/conda-package.yml | Introduced new workflow steps to retrieve and utilize the package version in the CI process. |
Comments suppressed due to low confidence (1)
.github/workflows/conda-package.yml:143
- Using PACKAGE_VERSION in the package installation command is a good approach; however, ensure that the version extraction step reliably produces a valid version string to prevent installation mismatches during the CI process.
conda create -n ${{ env.TEST_ENV_NAME }} $PACKAGE_NAME=${{ env.PACKAGE_VERSION }} python=${{ matrix.python }} pytest "scipy>=1.10" $CHANNELS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running tests on Linux in the CI with python 3.9 and 3.10,
mkl_fftpackage was installed fromhttps://software.repos.intel.com/python/condaand not the local channel. This PR fixes it to always installmkl_fftfrom local channel.In addition, the only scipy available for python 3.9 and 3.10 from
https://software.repos.intel.com/python/condaisscipy=1.10.1which requiresmkl>=2024.2,<2025. Therfore,mkl-develis pinned for python 3.9 and 3.10 inmeta.yamlfile.