use PyLong_AsLong instead of PyInt_AsLong#182
Merged
Conversation
vtavana
force-pushed
the
use-PyLong_AsLong
branch
from
d39a77d to
b86036b
Compare
vtavana
requested review from
antonwolfy,
ekomarova,
ndgrigorian and
xaleryb
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the conda packaging workflows to adjust dependency installation steps and environment creation commands. Key changes include:
- Splitting the environment creation and package installation steps.
- Removing "pytest-cov" from the test dependencies configuration.
- Aligning dependency version specifications for scipy.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/conda-package.yml | Modified environment creation and restructured package installation; removed "pytest-cov". |
| .github/workflows/conda-package-cf.yml | Updated test dependency settings and adjusted installation arguments similarly. |
Files not reviewed (1)
- mkl_fft/_pydfti.pyx: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/conda-package.yml:299
- [nitpick] The removal of 'pytest-cov' from TEST_DEPENDENCIES may affect test coverage reporting. If this change is intentional, please confirm that test coverage is handled elsewhere.
SET "TEST_DEPENDENCIES=pytest scipy"
.github/workflows/conda-package-cf.yml:298
- [nitpick] The removal of 'pytest-cov' from TEST_DEPENDENCIES might impact code coverage collection. Ensure that this change aligns with the intended testing strategy.
SET "TEST_DEPENDENCIES=pytest scipy"
ndgrigorian
approved these changes
May 15, 2025
Collaborator
ndgrigorian
left a comment
ndgrigorian
left a comment
There was a problem hiding this comment.
LGTM! Given that it was part of Python 2 C API I'm surprised it was ever even used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyInt_AsLongis deprecated andPyLong_AsLongshould be used with python3.