Conversation
vtavana
force-pushed
the
fix-dtype-error
branch
4 times, most recently
from
bcfbb46 to
0231689
Compare
vtavana
requested review from
antonwolfy,
ekomarova,
ndgrigorian and
xaleryb
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue related to the handling of real inputs for the irfft function and improves consistency across tests and workflows. Key changes include:
- Updating test conditions for various scipy versions and adding new tests for irfft data type consistency.
- Modifying implementations in the numpy FFT interface functions to correct conjugation handling.
- Adjusting GitHub workflow commands to update package installation steps.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mkl_fft/tests/third_party/scipy/test_basic.py | Simplified skip calls and updated version range comments |
| mkl_fft/tests/test_fft1d.py | Added new test (test_irfft_dtype) to validate irfft output dtypes |
| mkl_fft/interfaces/_numpy_fft.py | Adjusted conjugation in hfft and renamed output variable in ihfft |
| CHANGELOG.md | Updated changelog entries for fixed input/output dtype inconsistency |
| .github/workflows/conda-package.yml | Modified conda commands for environment creation and package install |
| .github/workflows/conda-package-cf.yml | Similar modifications to conda install commands in continuous flow |
Files not reviewed (1)
- mkl_fft/_pydfti.pyx: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
antonwolfy
approved these changes
May 15, 2025
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM, a small nit/question below
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #176