Conversation
f162a5b to
835563c
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the package structure to prepare for future development without modifying the numerical functionality. Key changes include:
- Creating a new _mkl_fft.py file to expose public FFT functions.
- Moving functions from _pydft.pyx to _fft_util.py and shifting FFT interface code into the interfaces directory.
- Reorganizing imports and removing the obsolete _numpy_fft.py file.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mkl_fft/tests/test_fftnd.py | Updated tests to reference the new FFT interface at mkl_fft/interfaces/numpy_fft.py |
| mkl_fft/interfaces/scipy_fftpack.py | Changed the import style to align with the new package structure |
| mkl_fft/interfaces/numpy_fft.py | Moved FFT-related function definitions from _numpy_fft to the interfaces module |
| mkl_fft/interfaces/_float_utils.py | Adjusted docstrings to reflect the new module names |
| mkl_fft/_numpy_fft.py | Removed in favor of the new _mkl_fft.py file |
| mkl_fft/_mkl_fft.py | New module containing the core FFT function implementations |
| mkl_fft/init.py | Updated to expose FFT functions from the new _mkl_fft.py and re-export legacy functions |
Comments suppressed due to low confidence (2)
mkl_fft/interfaces/scipy_fftpack.py:27
- [nitpick] Consider using a relative import (e.g., 'from .. import mkl_fft') instead of an absolute import for consistency within the package structure.
import mkl_fft
mkl_fft/init.py:42
- [nitpick] Since the majority of FFT functions are now exposed through _mkl_fft, consider consolidating irfftpack and rfftpack within that module for a more consistent public API.
from ._pydfti import irfftpack, rfftpack # pylint: disable=no-name-in-module
835563c to
5c0ae88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, the structure of the package is updated to facilitate future development.
The following changes are made:
_mkl_fft.pyis created, and the exposed functions from the package are placed in this file (moved from_pydfti.pyxto this file)._pydfti.pyxare transferred to_fft_util.py._numpy_fft.py,_scipy_fft.py,_scipy_fftpack.pyand_float_util.pyare moved to the interfaces directory.Note that the content of the functions and their functionality is not modified in this PR.