fix: typos, code cleanup, noarch incorrectness#33
Open
jharlow-intel wants to merge 3 commits intoIntelPython:mainfrom
Open
fix: typos, code cleanup, noarch incorrectness#33jharlow-intel wants to merge 3 commits intoIntelPython:mainfrom
jharlow-intel wants to merge 3 commits intoIntelPython:mainfrom
Conversation
jharlow-intel
requested review from
antonwolfy,
ndgrigorian and
xaleryb
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a
systemwisetypo for one of the fallback commands, that's fixed now.Also removed noarch implementation - this package will no longer be installable on windows starting with this latest build number. Not sure why it ever was to be honest.
Mild change to post-link fallback behavior. I found it weird to say "folder does not exist" - and then use that path to create a symlink. Sounds like it would be a dangling link to me, unless that was somehow the intended behavior. The scripts probably could have used way more comments in them.
Because we no longer create a dangling link, I had to change the tests, too. Saw it happen immediately with the github actions - the directory didn't exist but we were creating the dangling link and then testing for it. Seemed strange
Lastly, removed upload workflow, we're moving it to conda-forge soon anyways