Skip to content

Implement dpnp.isin #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndgrigorian merged 11 commits into from
Dec 19, 2025
Merged

Implement dpnp.isin #2595

ndgrigorian merged 11 commits into from
Dec 19, 2025
+222 −1

Conversation

@ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Sep 25, 2025

This PR leverages the recently-added dpctl.tensor.isin to implement dpnp.isin

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_35 ran successfully.
Passed: 1228
Failed: 1
Skipped: 7

@coveralls
Copy link
Collaborator

coveralls commented Sep 25, 2025 •
edited
Loading

Coverage Status

coverage: 81.301% (+0.01%) from 81.291%
when pulling 155910a on reuse-tensor-isin
into 4a0d4e1 on master.

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Oct 7, 2025
antonwolfy
antonwolfy reviewed Oct 9, 2025
View reviewed changes
@ndgrigorian ndgrigorian force-pushed the reuse-tensor-isin branch 6 times, most recently from 7d29652 to 42e9893 Compare November 20, 2025 03:47
@ndgrigorian ndgrigorian marked this pull request as ready for review November 20, 2025 04:32
antonwolfy
antonwolfy reviewed Nov 20, 2025
View reviewed changes
@ndgrigorian ndgrigorian force-pushed the reuse-tensor-isin branch 4 times, most recently from 77d5512 to 02dd391 Compare November 21, 2025 09:06
antonwolfy
antonwolfy reviewed Dec 14, 2025
View reviewed changes
@ndgrigorian ndgrigorian force-pushed the reuse-tensor-isin branch 2 times, most recently from 885c635 to ba1cbf5 Compare December 17, 2025 07:30
@ndgrigorian ndgrigorian force-pushed the reuse-tensor-isin branch 2 times, most recently from 9c09ffc to c6f97a2 Compare December 18, 2025 03:22
antonwolfy
antonwolfy reviewed Dec 18, 2025
View reviewed changes
antonwolfy
antonwolfy reviewed Dec 19, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian, no more comments from

@ndgrigorian ndgrigorian merged commit eec0495 into master Dec 19, 2025
83 of 95 checks passed
@ndgrigorian ndgrigorian deleted the reuse-tensor-isin branch December 19, 2025 18:32
github-actions bot added a commit that referenced this pull request Dec 19, 2025
@github-actions
Merge pull request #2595 from IntelPython/reuse-tensor-isin
4265e40 
Implement `dpnp.isin` eec0495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @coveralls @antonwolfy