[hec-assembler]: Fix suggested bank error#78
Merged
Conversation
Collaborator
|
Actively testing this for outliers currently |
Contributor
|
Hi @joserochh , is this ready for revision? |
kylanerace
approved these changes
Jun 6, 2025
Collaborator
kylanerace
left a comment
There was a problem hiding this comment.
Tested out and not seeing any regressions in functionality/performance beyond some execution time. LGTM
Contributor
|
@joserochh I guess this is good to merge. It would be good to do so before Christopher rebases his branch, to avoid having to rebase this one again. |
christopherngutierrez
pushed a commit
that referenced
this pull request
Jun 10, 2025
Fixes suggested bank error Co-authored-by: Kylan Race <kylan.e.race@intel.com> Co-authored-by: Flavio Bergamaschi <faberga@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix suggested bank error by adding dependencies to eviction XStore instructions. This avoids instructions coming before a variable is allocated in correct bank.
Types of changes
What types of changes does your code introduce to the Encrypted Computing SDK project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.