Conversation
|
@christopherngutierrez Can you add a couple of examples using here in the discussion to show: Got questions answered separately. |
kylanerace
left a comment
There was a problem hiding this comment.
Non-breaking change, adds additional functionality. LGTM
faberga
left a comment
There was a problem hiding this comment.
Better call this file options_handler.py so not confuse/imply this files is optional.
Also make corresponding changes to the "imports" that use this file.
Everything else looks okay.
Done! |
…eflect changes, and updated test case.
Parameter Options Handler
Proposed changes
Types of changes
What types of changes does your code introduce to the HE Toolkit project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did, what alternatives you
considered, etc.