STYLE: Remove Initialize() calls on new point sets RegisterTwoPointSets#434
Open
N-Dekker wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Open
Conversation
When a point set is just created by `New()`, it is already properly initialized. - Follow-up to pull request InsightSoftwareConsortium/ITK#4976 commit InsightSoftwareConsortium/ITK@bc044c1 "STYLE: Remove p->Initialize() call after p = T::New() in example"
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
area:Registration
dzenanz
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a point set is just created by
New(), it is already properly initialized.p->Initialize()calls directly afterp = T::New(), in tests and example ITK#4976 commit InsightSoftwareConsortium/ITK@bc044c1 "STYLE: Remove p->Initialize() call after p = T::New() in example"@tbirdso Just a minor stylish PR, please have a look!