ENH: Revive ExtractContoursFromImage as SimpleContourExtractor#432
Open
dzenanz wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Open
ENH: Revive ExtractContoursFromImage as SimpleContourExtractor#432dzenanz wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
dzenanz wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
github-actions
bot
added
type:Enhancement
jhlegarreta
reviewed
Nov 11, 2024
Member
jhlegarreta
left a comment
jhlegarreta
left a comment
There was a problem hiding this comment.
What is the reason to rename the example? Isn't ExtractContoursFromImage more meaningful that SimpleContourExtractor?
Member
Author
|
Name conflict.
Written on cellphone, excuse my brevity.
…On Mon, Nov 11, 2024, 17:33 Jon Haitz Legarreta Gorroño < ***@***.***> wrote:
***@***.**** commented on this pull request.
What is the reason to rename the example? Isn't ExtractContoursFromImage
more meaningful that SimpleContourExtractor?
—
Reply to this email directly, view it on GitHub
<#432 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANVQ6OZWJOUIIYJOWMGGVL2AEWFFAVCNFSM6AAAAABRSFCYVSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMRYGI3TKMBVGY>
.
You are receiving this because you authored the thread.Message ID:
<InsightSoftwareConsortium/ITKSphinxExamples/pull/432/review/2428275056@
github.com>
|
Member
|
Then there is maybe some more work to do to distinguish/document better the existing and the revived examples: https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/master/src/Filtering/Path/ExtractContoursFromImage/Documentation.rst The revived rst file says that it is unfinished. |
Member
Author
|
build-test-documentation (ubuntu-22.04) is timing out. |
Member
|
@dzenanz Could you please rebase this for consideration? |
The example was commented out since the initial import commit: ENH: Adding media wiki examples to sphinx examples a82f59e
dzenanz
force-pushed
the
simpleContourExtractor
branch
from
77eb9d8 to
93762d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example was commented out since the initial import commit:
ENH: Adding media wiki examples to sphinx examples (a82f59e)