ENH: add SmoothImageWithDiscreteGaussianFilter python example#372
Open
RomanFenioux wants to merge 3 commits intoInsightSoftwareConsortium:mainfrom
Open
ENH: add SmoothImageWithDiscreteGaussianFilter python example#372RomanFenioux wants to merge 3 commits intoInsightSoftwareConsortium:mainfrom
RomanFenioux wants to merge 3 commits intoInsightSoftwareConsortium:mainfrom
Conversation
github-actions
bot
added
area:Documentation
tbirdso
reviewed
May 20, 2022
Contributor
tbirdso
left a comment
tbirdso
left a comment
There was a problem hiding this comment.
Great start! Please see comments for Pythonic equivalents of ITK filters.
src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/Code.py
Outdated
Show resolved
Hide resolved
thewtex
previously requested changes
May 20, 2022
Member
thewtex
left a comment
thewtex
left a comment
There was a problem hiding this comment.
@RomanFenioux well done!!
CI is failing because it expects an image for the test.
Exception detected while reading /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png :
itk::ImageFileReaderException (0x5594a8e5f4d0)
Location: "unknown"
File: /home/runner/work/bld/ITK/Modules/IO/ImageBase/include/itkImageFileReader.hxx
Line: 132
Description: Could not create IO object for reading file /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png
The file doesn't exist.
Filename = /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png
Exception detected while reading /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png :
itk::ImageFileReaderException (0x5594a8e5d740)
Location: "unknown"
File: /home/runner/work/bld/ITK/Modules/IO/ImageBase/include/itkImageFileReader.hxx
Line: 132
Description: Could not create IO object for reading file /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png
The file doesn't exist.
Filename = /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png
For more information on how to add this image, please see the other examples and the documentation here: https://examples.itk.org/documentation/contribute/uploadbinarydata
github-actions
bot
added
the
type:Data
This was referenced May 20, 2022
Author
|
Hi @thewtex |
Member
|
Hi @RomanFenioux looking great! Could you please rebase on |
RomanFenioux
force-pushed
the
Modification
branch
from
43ae8c1 to
afa5c63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.