geodesic notebook

[thewtex]

• STYLE: GeodesicActiveContour CMake style
• DOC: Add notebook example for SegmentWithGeodesicActiveContourLevelSet

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[dzenanz]

Point picker for itkwidgets would come in handy here for interactive experimentation.

Reply via ReviewNB

[thewtex]

Yes, on the agenda :-).

[dzenanz]

Is there an already existing example of how a Jupyter notebook looks like when rendered in sphinx examples?

[thewtex]

Is there an already existing example of how a Jupyter notebook looks like when rendered in sphinx examples?

https://itk.org/ITKExamples/src/Registration/Metricsv4/RegisterTwoPointSets/Documentation.html

[jhlegarreta]

Have not tried, but looks good. 💯 for doing this !

[jhlegarreta]

A minor comment: maybe the Jupyter notebook execution-related cell data (e.g. execution_count) can be cleared before merging? Not sure if this has been in other notebooks. nbconvert can do this automatically if I'm not mistaken,

jupyter nbconvert --ClearOutputPreprocessor.enabled=True --clear-output *.ipynb

but it would also clear the output images, if any, I think. Maybe the SimpleITK folks know better how to do this.

At term, maybe having a pre-commit hook taking care of this cleaning could be handy.

[thewtex]

@jhlegarreta good ideas.

I will remove the cell output for this notebook, but we will likely want to add it back in the future when itkwidgets saves a more meaningful visualization. Our other notebooks have matplotlib output, which is useful to have saved in the notebook output when browsing on GitHub or nbviewer.

[tbirdso]

Looks great! Notebook is helpful for following each step.

[hjmjohnson]

@thewtex This would need to be rebased before considering again.