Conversation
Member
hjmjohnson
commented
Jan 26, 2025
hjmjohnson
commented
- STYLE: Add itkVirtualGetNameOfClassMacro + itkOverrideGetNameOfClassMacro
- STYLE: CoordRepType -> CoordinateType code readability
hjmjohnson
force-pushed
the
use-CoordinateType
branch
5 times, most recently
from
7a4171d to
0ac6f52
Compare
…acro Added two new macro's, intended to replace the old 'itkTypeMacro' and 'itkTypeMacroNoParent'. The main aim is to be clearer about what those macro's do: add a virtual 'GetNameOfClass()' member function and override it. Unlike 'itkTypeMacro', 'itkOverrideGetNameOfClassMacro' does not have a 'superclass' parameter, as it was not used anyway. Note that originally 'itkTypeMacro' did not use its 'superclass' parameter either, looking at commit 699b66cb04d410e555656828e8892107add38ccb, Will Schroeder, June 27, 2001: https://github.com/InsightSoftwareConsortium/ITK/blob/699b66cb04d410e555656828e8892107add38ccb/Code/Common/itkMacro.h#L331-L337
For the sake of code readability, a new 'CoordinateType' alias is added for each nested 'CoordRepType' alias. The old 'CoordRepType' aliases will still be available with ITK 6.0, but it is recommended to use 'CoordinateType' instead. The 'CoordRepType' aliases will be removed when 'ITK_FUTURE_LEGACY_REMOVE' is enabled. Similarly, 'InputCoordinateType', 'OutputCoordinateType', and 'ImagePointCoordinateType' replace 'InputCoordRepType', 'OutputCoordRepType', and 'ImagePointCoordRepType', respectively.
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
0ac6f52 to
7bf400b
Compare
hjmjohnson
force-pushed
the
use-CoordinateType
branch
2 times, most recently
from
255c0f2 to
dea5144
Compare
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
dea5144 to
8f2fd1a
Compare
Member
Author
|
@dzenanz I've been working through this 1 PR to identify what needs to be done in many other remote modules to bring them up-to-date. Can you please have a more careful review of this one? |
Member
|
Sure. I expect to get to it within the next hour or so. |
dzenanz
reviewed
Jan 28, 2025
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Changes mostly look good.
This module is unusual as it does not have Python packages.
dzenanz
reviewed
Jan 28, 2025
Member
|
Also consider finishing up #98 and merging with the changes here. |
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
807739a to
0544b8f
Compare
dzenanz
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.