ENH: Improve AnisotropicDiffusionLBR tests#6282
Open
hjmjohnson wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
type:Infrastructure
This comment was marked as resolved.
This comment was marked as resolved.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
hjmjohnson
force-pushed
the
improve-anisotropicdiffusionlbr-tests
branch
from
0b29331 to
b8c20fa
Compare
hjmjohnson
force-pushed
the
improve-anisotropicdiffusionlbr-tests
branch
2 times, most recently
from
fb69ed5 to
7af3d51
Compare
Address the test-quality items tracked in InsightSoftwareConsortium#6283 (originally ITKAnisotropicDiffusionLBR#26) for the ingested module: - Relocate the two test-only command-line headers out of include/: CoherenceEnhancingDiffusionCommandLine.h is folded into test/CoherenceEnhancingDiffusionTest.cxx (anonymous namespace); the dead LinearAnisotropicDiffusionCommandLine.h is removed and replaced by a LinearAnisotropicDiffusionLBRImageFilter GoogleTest. - Use ITK testing macros (ITK_TRY_EXPECT_NO_EXCEPTION, ITK_GTEST_EXERCISE_BASIC_OBJECT_METHODS). - The new GoogleTest uses fault-tolerant non-fatal EXPECT_* assertions so all checks run and the status is aggregated; the 16 image-regression tests intentionally keep per-invocation CTest --compare status. - Replace the terse argument check with a clear itkGenericExceptionMacro usage message (also fixes a latent silent success on too-few args). - Remove progress/parameter/timing prints and dead commented-out debug code. - Conform to enforced ITK style. All 16 image-regression baselines are unchanged. Original test-improvement report by jhlegarreta: ITKAnisotropicDiffusionLBR#26. Closes InsightSoftwareConsortium#6283
hjmjohnson
force-pushed
the
improve-anisotropicdiffusionlbr-tests
branch
from
7af3d51 to
8f07f47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6283 (originally InsightSoftwareConsortium/ITKAnisotropicDiffusionLBR#26, @jhlegarreta).
Test-quality improvements for the ingested
Modules/Filtering/AnisotropicDiffusionLBR: relocates the two test-only CLI headers out ofinclude/, modernizes to ITK test macros, adds aLinearAnisotropicDiffusionLBRImageFilterGoogleTest, clarifies the usage message, removes noisy prints, and conforms to ITK style. All 16 image-regression baselines unchanged. Single squashed commit on currentupstream/main.Issue #6283 ask → change
CoherenceEnhancingDiffusionCommandLine.hfolded intotest/CoherenceEnhancingDiffusionTest.cxx(anon namespace); deadLinearAnisotropicDiffusionCommandLine.hremoved, replaced by a GoogleTestITK_TRY_EXPECT_NO_EXCEPTION,ITK_GTEST_EXERCISE_BASIC_OBJECT_METHODSEXPECT_*(aggregated status); the 16 image-regression tests intentionally keep per-invocation CTest--comparestatusitkGenericExceptionMacro(also fixes a latent silent-EXIT_SUCCESS on too-few-args)pre-commit run --all-filescleanValidation
Built with
Module_AnisotropicDiffusionLBRonly; all 16 functional--comparetests + Doxygen pass (baselines byte-identical), newLinearAnisotropicDiffusionLBRImageFilter.SmokeTestGoogleTest passes. KWStyle exercised by CI.