Skip to content

ENH: Make ITK_CMAKE_DIR an internal cache variable#5962

Draft
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
blowekamp:cache_itk_cmake_dir
Draft

ENH: Make ITK_CMAKE_DIR an internal cache variable#5962
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
blowekamp:cache_itk_cmake_dir

Conversation

@blowekamp
Copy link
Member

@blowekamp blowekamp commented Mar 17, 2026

When building ITK with FetchConent, ITK_CMAKE_DIR is needed in the parent project for configurations paths, and in the itk_generate_factory_registration macro.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@blowekamp
ENH: Make ITK_CMAKE_DIR an internal cache variable
55564bd 
When building ITK with FetchConent, ITK_CMAKE_DIR is needed in the
parent project for configurations paths, and in the
itk_generate_factory_registration macro. Making this variable enables
it to be access by the parent project.
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Enhancement Improvement of existing methods or implementation labels Mar 17, 2026
@blowekamp
Copy link
Member Author

blowekamp commented Mar 17, 2026

/azp run ITK.Windows

@blowekamp
Copy link
Member Author

blowekamp commented Mar 17, 2026

I think this Windows is only failing because of "'|': unsafe mix of type 'bool' and type 'int' "

@blowekamp blowekamp marked this pull request as ready for review March 17, 2026 19:28
@blowekamp blowekamp marked this pull request as draft March 17, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blowekamp @dzenanz