ENH: Use standard header approach for eigen e.g. itk_Eigenvalues#5952
Draft
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Draft
ENH: Use standard header approach for eigen e.g. itk_Eigenvalues#5952blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
This approach for headers works when a third party is a system or from the itk build system. It has the advantage that it prevents a system include ( or some other vendors packaged library). Additionally, it is consistent with other ITK third-party libraries.
github-actions
bot
added
type:Infrastructure
3 tasks
dzenanz
reviewed
Mar 16, 2026
| endif() | ||
|
|
||
| # Generate a wrapper header for every Eigen module header so that | ||
| # consumers can write #include "Eigen/Core" etc. and get either the |
Member
There was a problem hiding this comment.
This is contradictory to the change in Modules/Core/Common/include/itkSymmetricEigenAnalysis.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach for headers works when a third party is a system or from the itk build system. It has the advantage that it prevents a system include ( or some other vendors packaged library). Additionally, it is consistent with other ITK third-party libraries.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.