COMP: Let Future.get() calls in PoolMultiThreader always return void#5950
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:mainfrom Mar 16, 2026
Merged
Conversation
github-actions
bot
added
type:Compiler
N-Dekker
force-pushed
the
PoolMultiThreader-Future-void
branch
from
a22aedb to
af0c4e3
Compare
`Future` was declared as `std::future<ITK_THREAD_RETURN_TYPE>`, which is platform specific, and caused warnings on some platforms, as reported by Hans Johnson at InsightSoftwareConsortium#5945 : itkPoolMultiThreader.cxx:148:55: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result] exceptionHandler.TryAndCatch([this, threadLoop] { m_ThreadInfoArray[threadLoop].Future.get(); }); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Addressed by replacing the public `ThreadPoolInfoStruct` with a private `InternalWorkUnitInfo` struct, which has its `Future` declared as `std::future<void>`.
N-Dekker
force-pushed
the
PoolMultiThreader-Future-void
branch
from
af0c4e3 to
fd7c78b
Compare
dzenanz
approved these changes
Mar 15, 2026
2 tasks
Member
|
ARM build failures are un-related and resolved in |
hjmjohnson
approved these changes
Mar 16, 2026
hjmjohnson
merged commit 912328d
into
InsightSoftwareConsortium:main
17 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Futurewas declared asstd::future<ITK_THREAD_RETURN_TYPE>, which is platform specific, and caused warnings on some platforms, as reported by Hans Johnson (@hjmjohnson) at #5945 :Addressed by using
std::future<void>instead.