WIP: Replace "vnl_sample.h" with <random> in ConnectedComponent tests#5622
Closed
N-Dekker wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Closed
WIP: Replace "vnl_sample.h" with <random> in ConnectedComponent tests#5622N-Dekker wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
<random> in ConnectedComponent tests#5622N-Dekker wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
Contributor
Author
|
18ae855 to
3324070
Compare
<random> in Segmentation tests<random> in ConnectedComponent tests
Contributor
Author
|
There appeared test failures at https://open.cdash.org/viewTest.php?onlyfailed&buildid=10817138 on the following four tests:
I'm sorry, I don't really know how to fix them, but I guess we would have to change the ground truth images (somewhere in ITK/Modules/Segmentation/ConnectedComponents/test/CMakeLists.txt Lines 44 to 55 in 6568876 Does anyone have suggestion? |
dzenanz
reviewed
Nov 12, 2025
Modules/Segmentation/ConnectedComponents/test/itkConnectedComponentImageFilterTest.cxx
Show resolved
Hide resolved
hjmjohnson
reviewed
Nov 12, 2025
Modules/Segmentation/ConnectedComponents/test/itkConnectedComponentImageFilterTest.cxx
Outdated
Show resolved
Hide resolved
3324070 to
3dec7c3
Compare
Follow-up to pull request InsightSoftwareConsortium#5611 commit f7daf24 "ENH: Replace "vnl/vnl_sample.h" with `<random>`, in Core tests"
3dec7c3 to
d993427
Compare
CavRiley
added a commit
to CavRiley/ITK
that referenced
this pull request
Jan 8, 2026
Follow-up to pull request InsightSoftwareConsortium#5622 commit d993427 "ENH: Replace "vnl_sample.h" with <random> in ConnectedComponent tests" The random number generator change affected test outputs, requiring updated baseline images.
7 tasks
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<random>, in Core tests #5611