Add and use ProcessObject::MakeRequiredOutputs#4688
Merged
hjmjohnson merged 3 commits intoInsightSoftwareConsortium:masterfrom Jun 18, 2024
Merged
Add and use ProcessObject::MakeRequiredOutputs#4688hjmjohnson merged 3 commits intoInsightSoftwareConsortium:masterfrom
ProcessObject::MakeRequiredOutputs#4688hjmjohnson merged 3 commits intoInsightSoftwareConsortium:masterfrom
Conversation
github-actions
bot
added
area:Core
N-Dekker
force-pushed
the
SetRequiredOutputs
branch
from
c0c14a0 to
b23ad5b
Compare
github-actions
bot
added
the
area:Registration
N-Dekker
force-pushed
the
SetRequiredOutputs
branch
4 times, most recently
from
cafc8f5 to
5d3c7ca
Compare
Contributor
Author
|
/azp run ITK.Windows |
Meant to be used in constructors of derived classes that would otherwise directly call `MakeOutput` for each of their required outputs.
Paved the way for those filters to use `ProcessObject::MakeRequiredOutputs`. `MakeOutput` member functions are usually declared public, rather than protected.
Reduced amount of duplicate code in constructors that "make" all of their required outputs.
N-Dekker
force-pushed
the
SetRequiredOutputs
branch
from
5d3c7ca to
ddbed4a
Compare
N-Dekker
changed the title
ProcessObject::SetRequiredOutputsProcessObject::MakeRequiredOutputs
Member
|
@blowekamp Brad would you mind double checking that this looks OK? |
blowekamp
requested changes
Jun 12, 2024
Member
blowekamp
left a comment
blowekamp
left a comment
There was a problem hiding this comment.
There are some cases there the correct derive MakeOutput is no longer called.
Modules/Filtering/DistanceMap/include/itkDanielssonDistanceMapImageFilter.hxx
Show resolved
Hide resolved
blowekamp
approved these changes
Jun 12, 2024
Modules/Filtering/DistanceMap/include/itkDanielssonDistanceMapImageFilter.hxx
Show resolved
Hide resolved
This was referenced Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetNthOutput(i, MakeOutput(i))in aforloop #4687