Skip to content

Conversation

@ReneeVandervelde
Copy link
Member

@ReneeVandervelde ReneeVandervelde commented Jul 6, 2025

Update to a more recent sdk version for Android

This should fix the crash in #96

@ReneeVandervelde ReneeVandervelde requested a review from Copilot July 6, 2025 15:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to target Android SDK 34+ by bumping compileSdk/targetSdk, adding new foreground‐service permissions, and introducing an audio‐specific background service.

  • Upgrade compileSdk/targetSdk in both modules.
  • Expand driver permission sets to include FOREGROUND_SERVICE_LOCATION and FOREGROUND_SERVICE_MICROPHONE on API 34+.
  • Add an BackgroundCaptureServiceAudio subclass and update manifest entries for separate audio vs. location services.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
aprs-android/build.gradle.kts Bumped compileSdk from 33 to 34.
android-application/build.gradle.kts Bumped compileSdk/targetSdk from 34 to 35.
TncDriver.kt / InternetDriver.kt / AfskDriver.kt Added API 34+ branches for new foreground service permissions in receivePermissions and transmitPermissions.
AndroidSymbolFactory.kt Added null‐safe fallback for Bitmap.Config.
BackgroundCaptureService.kt / CaptureActivity.kt Made BackgroundCaptureService open, added BackgroundCaptureServiceAudio, and wired audio vs. default service intents.
android-application/src/main/AndroidManifest.xml Added new permissions and split the background service into two entries for audio vs. location.
Comments suppressed due to low confidence (1)

android-application/src/main/java/com/inkapplications/ack/android/capture/service/BackgroundCaptureService.kt:55

  • [nitpick] The subclass BackgroundCaptureServiceAudio name doesn't match the manifest entry BackgroundCaptureServiceAfsk. Consider renaming to BackgroundCaptureServiceAfsk for consistency.
class BackgroundCaptureServiceAudio: BackgroundCaptureService()

@ReneeVandervelde ReneeVandervelde changed the title Update to Android 34 SDK Update to Android 35 SDK Jul 6, 2025
@ReneeVandervelde ReneeVandervelde disabled auto-merge July 6, 2025 16:00
It seems we need background permissions for the foreground service
to run on newer versions, even when the app itself is still in the
foreground.
Would like a more elegant solution and dialog here, but this gets the
point across for now.
@ReneeVandervelde ReneeVandervelde merged commit ab11657 into master Jul 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants