Disable LowerWrist during sleep mode #2415
Open
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
mark9064
reviewed
Feb 8, 2026
src/systemtask/SystemTask.cpp
Outdated
| } | ||
| if (settingsController.isWakeUpModeOn(Pinetime::Controllers::Settings::WakeUpMode::LowerWrist) && state == SystemTaskState::Running && | ||
| motionController.ShouldLowerSleep()) { | ||
| motionController.ShouldLowerSleep() && (settingsController.GetNotificationStatus() != Controllers::Settings::Notification::Sleep)) { |
Member
There was a problem hiding this comment.
Move into the if block above instead (it already checks the condition)
Contributor
There was a problem hiding this comment.
which line do you mean? Could you clarify?
Member
There was a problem hiding this comment.
L458 already checks (settingsController.GetNotificationStatus() != Controllers::Settings::Notification::Sleep)
So the lower wrist check can move to L465 and the extra check of the notification status is not needed
Contributor
Author
There was a problem hiding this comment.
Should be good now 👍
NeroBurner
approved these changes
Feb 9, 2026
Contributor
NeroBurner
left a comment
NeroBurner
left a comment
There was a problem hiding this comment.
the change looks sound to me. Need to check on device when I get round to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users have noticed that sleep mode disables wrist raise wake, but not wrist lower sleep, which is inconsistent and sometimes annoying. This PR fixes that by not sleeping the device if you lower your wrist when sleep mode is enabled.
Fixes #2030