feat(triton): add AOT backend with Add operator#649
Draft
fuyou4546 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WITH_TRITON) built on Triton's AOT compiler. Operators live undersrc/triton/ops/<op>/and are compiled to cubins + C dispatchers at CMake configure time.scripts/generate_triton_ops.pyto walk the operator tree and invoke each operator'sbuild.pyscripts/generate_wrappers.pywith a--with-tritonflag so the generated dispatch table picksup Triton implementations.
WITH_TRITONthroughCMakeLists.txtandsrc/CMakeLists.txt: new option, mutual exclusionwith non-NVIDIA backends,
enable_language(C)for the generated.cfiles, and aTRITON_PYTHON_EXECUTABLEcache var mirroring the NineToothed pattern.Addas the first operator (src/triton/ops/add/{add.py,build.py,add.h}), registered asOperator<Add, kNvidia, 8>.Motivation
Triton is not yet integrated into InfiniOps. Adding a Triton backend lets contributors write kernels in Python instead of CUDA C++, plugs cleanly into the existing
Operator<...>dispatch via AOT‑compiled kernels, and lays the groundwork for reaching non‑NVIDIA targets as Triton’s upstream support expands.Addships as the first operator to validate the end‑to‑end pipeline.Closes #N/A
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Test Results on Supported Platforms
pytestResultpytest tests/test_add.py -k cuda-8→ 108 passed, 0 failedFull `pytest` output (optional)
Benchmark / Performance Impact
"N/A"
Notes for Reviewers
This PR integrates Triton via the AOT pipeline; the overall flow mirrors the existing
WITH_NINETOOTHEDintegration (CMakeLists.txtoption, codegen script,*_PYTHON_EXECUTABLEcache var, generated.cdispatchers).Addis the first operator.Checklist
Title, Branch, and Commits
feat(nvidia): …,fix(cuda/gemm): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene (applies to all languages)
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `seqlens_k` tensor) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 21, per.github/workflows/clang-format.yml) has been run against all modified.h,.cc,.cuh, and.mlufiles; the diff is clean.clang-tidyconcerns (per.clang-tidy) have been reviewed — no new warnings beyond the existing baseline.CONTRIBUTING.md§C++).assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).kernel/kernel_v2/ …; well-known algorithms use the algorithm name; library-based implementations use the library name (CONTRIBUTING.md§C++)..cuh+.cufor kernel — Triton AOT generates.cfiles instead of CUDA source; the extern "C" block in add.h includes the generated launchers directly, matching the pattern insrc/ninetoothed/ops/<op>/<op>.h.CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).src/base/<op>.h(inheritingOperator<Op>) with platform implementations undersrc/<category>/<platform>/inheriting the base (CONTRIBUTING.md§Adding an Operator).new/delete; RAII / smart pointers / existing allocators are used.Python Specific (if Python files changed)
ruff checkpasses cleanly on CI (see.github/workflows/ruff.yml).ruff format --checkpasses cleanly — if not, runruff formatand commit the result.CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).if,for, and similar control-flow statements (CONTRIBUTING.md§Python).return, except when it directly follows a control-flow statement (CONTRIBUTING.md§Python).Testing
pytestwas run locally on every supported platform that this PR can affect, and the results are recorded in the "Test Results" table above (CONTRIBUTING.md§Pull Requests).tests/followingtests/test_add.py/tests/test_gemm.pypatterns (CONTRIBUTING.md§Adding an Operator).pytest.mark.parametrizecorrectly: dependent parameters share one decorator (e.g.@pytest.mark.parametrize("dtype, rtol, atol", …)), independent parameters use separate decorators ordered by parameter declaration.dtype/deviceparameterization is relied on, or overridden with an explicitpytest.mark.parametrizewhen necessary.Build, CI, and Tooling
pip install .[dev]on at least one affected platform.compile_commands.jsonstill regenerates (CMake optionCMAKE_EXPORT_COMPILE_COMMANDS=ONinpyproject.toml— required by thecode-lintskill andclang-tidy -p).CMakeLists.txtunderif(AUTO_DETECT_DEVICES)and toif(AUTO_DETECT_BACKENDS)if applicable.CMakeLists.txtis not broken.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).pyproject.toml's[project.optional-dependencies](or justified in the PR description).Documentation
README.md/ CONTRIBUTING.md not updated — WITH_TRITON follows the exact same opt-in pattern as WITH_NINETOOTHED, which is similarly undocumented. Happy to add a section if requested.CONTRIBUTING.md§Some Code Explanations).Security and Safety