Basic comment function to each reviews#139
Closed
re1entlessly wants to merge 5 commits into
Closed
Conversation
re1entlessly
commented
May 14, 2025
re1entlessly
commented
Collaborator
Collaborator
|
Could you add an error field, that notifies the user if something goes wrong, e.g. one is not logged in. Personally I think it also would make sense to have the userid (model?.user?.uid) as a key for the subcomments. Then everyone can only comment once. Also the rules should specify that and disallow to overwrite if you dont own the uid of the subcomment. |
Collaborator
|
Could you also fix a delete button for the normal comments? |
Collaborator
|
Also you removed the ability to post anonymous... |
jkluge
requested changes
May 14, 2025
jkluge
left a comment
jkluge
left a comment
Collaborator
There was a problem hiding this comment.
Please:
- add error handling
- come up with a validation for subcomments (e.g. allow only one subcomment)
- restore the ability to post anonymously ^^
- if time, add a delete button :))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.