feat(mso_mdoc): rewrite using isomdl-uniffi & migrate to uv #10

burdettadam · 2025-12-02T00:12:58Z

This PR introduces a complete rewrite of the mso_mdoc plugin to use isomdl-uniffi for ISO 18013-5 compliance. It also migrates the project dependency management from Poetry to UV.

Key Changes:

mso_mdoc Rewrite: Replaced existing implementation with isomdl-uniffi bindings for better performance and compliance.
Dependency Management: Migrated from Poetry to UV for faster and more reliable package management.
Test Coverage: Expanded comprehensive test coverage and OID4VCI 1.0 compliance.
Integration: Updated Docker builds and integration tests to support the new architecture.

Note: This PR is being merged into a temporary upstream branch (temp/upstream-main) for integration testing before merging into the main codebase.

Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>

Signed-off-by: Micah Peltier <micah6_8@yahoo.com>

Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>

In an effort to push the mDL integration tests as far as possible, I have made the tweaks necessary to get the Sphereon test harness to recognize the service as adhering to the oid4vc draft 13 spec. I have also pushed the credo tests as far as I possibly could to the point where we are now seeing the same error that we're seeing within the Sphereon mobile app. Despite these changes, the Paradym wallet is still refusing to recognize the service as a valid oid4vc service. Interop Integration test status: - Sphereon now passes - Credo now complains about receiving all the data for the credential but not able to read everything needed to decode. If I understood the error correctly that is. It's late and I'm tired. Great progress made today! Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>

…at/mdoc Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>

Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>

Signed-off-by: Micah Peltier <micah6_8@yahoo.com>

Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>

…at/mdoc Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>

Signed-off-by: Char Howland <char@indicio.tech>

Signed-off-by: Micah Peltier <micah6_8@yahoo.com>

…repo - Convert pyproject.toml files from Poetry to UV format - Add isomdl-uniffi dependency from GitHub repository - Remove old local isomdl-uniffi binary files and wrapper - Delete poetry.lock file (no longer needed with UV) - Add missing dependencies (cwt, pycose, jsonpointer) for mso_mdoc and sd_jwt functionality Signed-off-by: Adam Burdett <burdettadam@gmail.com>

…compliance - Replace uniffi_scratch with isomdl-uniffi GitHub dependency for production-ready mDoc operations - Implement comprehensive credential processor with real cryptographic operations using P-256 ECDSA - Add persistent storage manager for secure key and certificate management - Introduce key generation utilities supporting EC P-256 and X.509 certificate creation - Remove mock-based testing in favor of real functional tests with actual mDoc operations - Add comprehensive test suite (49 tests) covering real integration, storage, and processing - Enhance documentation with ISO 18013-5 compliance references and API documentation - Implement robust string/bytes handling for various isomdl-uniffi output formats - Add security validations with proper exception handling and error context - Support selective disclosure and CBOR/COSE encoding per mobile document standards This implementation provides a complete, production-ready ISO 18013-5 compliant mobile document credential format with real cryptographic operations, comprehensive testing, and proper integration with ACA-Py's credential issuance framework. Files changed: 30 files changed, 4457 insertions(+), 4344 deletions(-) Key additions: storage.py, key_generation.py, 7 new comprehensive test files Key removals: uniffi_scratch/ directory, x509.py, mock-based test files Signed-off-by: Adam Burdett <burdettadam@gmail.com>

- Add extensive real data test suite (2600+ lines) achieving 49.57% coverage - Migrate from Poetry to UV package manager with isomdl-uniffi integration - Update credential configurations to OID4VCI 1.0 spec compliance - Transform mocked tests to real data implementations across all modules - Add comprehensive public route functionality tests with authentic workflows - Update MSO mDOC and JWT VC JSON credential processors for real data - Enhance integration test infrastructure with realistic credential scenarios - Add end-to-end OID4VC flows with university degrees, employment, identity credentials This commit represents a major improvement in test quality and specification compliance, moving from artificial mocked scenarios to production-ready test patterns with real credential data and authentic protocol workflows. Signed-off-by: Adam Burdett <burdettadam@gmail.com>

Major changes to support containerized integration testing: ## Docker Build Fixes - Fix docker/Dockerfile to use wheel file for isomdl-uniffi private dependency - Add isomdl_uniffi-0.1.0-py3-none-any.whl to docker/ directory - Remove entrypoint.sh and simplify container startup - Update integration/Dockerfile to use uv package manager - Remove isomdl_wrapper references, add wheel file support ## Integration Test Infrastructure - Simplified docker-compose.yml with core OID4VC services: - ACA-Py issuer/verifier agents with OID4VC plugin - Credo agent for credential wallet functionality - Add comprehensive health checks and service dependencies - Update pyproject.toml files to comment out git dependencies for Docker compatibility ## Test Coverage Additions - Add test_docker_connectivity.py: Network connectivity validation - Add test_acapy_oid4vc_simple.py: Basic OID4VC flow testing - Add test_acapy_to_credo_issuance.py: End-to-end credential issuance from ACA-Py to Credo - Add test_acapy_to_credo_to_acapy_flow.py: Complete round-trip flow - Fix async test decorators across test files - Update conftest.py with proper fixture configuration ## Credo Agent Updates - Update Credo wrapper to TypeScript with proper OID4VC support - Add @credo-ts dependencies for OpenID4VC protocols - Configure proper API endpoints and credential handling ## Infrastructure Cleanup - Remove Sphereon integration (sphereon/ directory and wrapper) - Remove isomdl_wrapper in favor of direct wheel file usage - Update README.md with new Docker build instructions ## Validation Results All core integration tests passing: - ✅ Docker network connectivity - ✅ ACA-Py health checks and credential offers - ✅ Simple OID4VC flow end-to-end - ✅ ACA-Py to Credo credential issuance This enables reliable containerized development and CI/CD integration testing for the OID4VC plugin with core functionality validated. Signed-off-by: Adam Burdett <burdettadam@gmail.com>

Migrated OID4VCI 1.0 and mDoc compliance tests from development files to the integration test suite. Added test configuration and utilities. Cleaned up consolidated test files. Signed-off-by: Adam Burdett <burdettadam@gmail.com>

Added run-tests.sh helper script and additional docker-compose configurations for development and full test suites. Updated .gitignore to exclude test-results. Signed-off-by: Adam Burdett <burdettadam@gmail.com>

Updated Docker Compose health checks and test commands. Temporarily disabled mso_mdoc plugin in dev config. Updated OID4VP flow to use new API endpoints. Cleaned up error handling in test scripts and fixed imports. Signed-off-by: Adam Burdett <burdettadam@gmail.com>