feat(core): document shading cloud, parameters flag and more#46
Open
feat(core): document shading cloud, parameters flag and more#46
Conversation
broccolai
force-pushed
the
build-system-suggestions
branch
from
601a28d to
7a905fb
Compare
broccolai
changed the title
Member
Author
|
maven / groovy in the parameters example needs to be checked |
main.py
Outdated
| <execution> | ||
| <phase>package</phase> | ||
| <goals> | ||
| <goal>shade</goal> |
Member
There was a problem hiding this comment.
Very minor nitpick but there's some missing indentation here
Co-authored-by: Alexander Söderberg <4096670+Citymonstret@users.noreply.github.com>
Citymonstret
approved these changes
Sep 1, 2024
jpenilla
requested changes
Sep 19, 2024
Member
jpenilla
left a comment
jpenilla
left a comment
There was a problem hiding this comment.
This should mention the need for mergeServiceFiles() with shadow and the maven equivalent, without it the provided ParserContributors and BrigadierMappingContributors will not work with relocations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://incendocloud--46.org.readthedocs.build/en/46/