Added all team member names;Need to add some styling#17
Open
rohankewal wants to merge 2 commits intoInVisionAR:masterfrom
Open
Added all team member names;Need to add some styling#17rohankewal wants to merge 2 commits intoInVisionAR:masterfrom
rohankewal wants to merge 2 commits intoInVisionAR:masterfrom
Conversation
arnavb
requested changes
Sep 21, 2020
Member
arnavb
left a comment
arnavb
left a comment
There was a problem hiding this comment.
The only problem I have with the styling is that the colors are default Bulma but that isn't a big deal.
When I was making the team page, I forgot that each person will probably have their own image, so I would like you to add a prop for the image source to the Person component. You can make it have a default value for the placeholder for now so that you don't have to convert all the code in about.js at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arnav please check out about.js since all names have been added. Am also looking for any styling suggestions you may have.