Replace include guards with #pragma once#1524
Open
johnhaddon wants to merge 2 commits intoImageEngine:mainfrom
Open
Replace include guards with #pragma once#1524johnhaddon wants to merge 2 commits intoImageEngine:mainfrom
#pragma once#1524johnhaddon wants to merge 2 commits intoImageEngine:mainfrom
Conversation
Contributor
|
LGTM |
Otherwise Clang on Mac complains like so : ``` In file included from include/IECore/ScaledDataConversion.h:62: include/IECore/ScaledDataConversion.inl:146:42: error: implicit conversion from 'std::numeric_limits<int>::type' (aka 'int') to 'float' changes value from 2147483647 to 2147483648 [-Werror,-Wimplicit-const-int-float-conversion] float result = static_cast<float>(f) * std::numeric_limits<T>::max(); ``` I'm not sure that hardcoding the usage of float in these function is a good idea - what if one of the types involved is double? But for now I am just making the behaviour of the original code explicit to get it passed the compiler unchanged.
Member
Author
|
I pushed 020fc3f to fix a compilation error on Mac - would be good if you could take a quick look at that please @danieldresser-ie. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.