hotfix(v1.3.15): submit subscriptions via ASC API#993
hotfix(v1.3.15): submit subscriptions via ASC API#993IgorGanapolsky wants to merge 2 commits intomainfrom
Conversation
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
|
| die( | ||
| "Could not enumerate subscriptions before App Review submission: " | ||
| f"{e}. Reference: {SUBSCRIPTION_REVIEW_DOC_URL}" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Bug: The exception handling for subscription enumeration was changed from a soft warning to a hard failure using die(), causing transient API errors to abort the entire app submission.
Severity: MEDIUM
Suggested Fix
Revert the error handling to be more resilient. Instead of calling die(), log a warning and allow the function to return, similar to the previous implementation. This prevents transient API errors from aborting the entire submission process. Alternatively, implement a retry mechanism for the API call.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: scripts/asc_submit_for_review.py#L973-L977
Potential issue: In the `_ensure_subscription_review_state` function, any exception
caught during the enumeration of app subscriptions now triggers a call to `die()`, which
raises a `SystemExit`. This is a regression from the previous behavior, which would log
a warning and continue. As a result, transient issues like network timeouts, rate
limiting, or temporary App Store Connect API outages will now cause the entire iOS app
submission process to abort, making the deployment pipeline less resilient.
Did we get this right? 👍 / 👎 to inform future reviews.
|
❌ CI Some checks failed
|
|
Superseded by later App Store submission fixes and the verified v1.3.17 release path. Closing this stale v1.3.15 hotfix PR. |



Summary
Why
Made with Cursor