Skip to content

hotfix(v1.3.15): submit subscriptions via ASC API#993

Closed
IgorGanapolsky wants to merge 2 commits intomainfrom
hotfix/v1.3.15-submission-fix
Closed

hotfix(v1.3.15): submit subscriptions via ASC API#993
IgorGanapolsky wants to merge 2 commits intomainfrom
hotfix/v1.3.15-submission-fix

Conversation

@IgorGanapolsky
Copy link
Copy Markdown
Owner

Summary

Why

  • branch policy validates hotfix version against app version (1.3.15)

Made with Cursor

(cherry picked from commit 15240bb)
(cherry picked from commit e3ee4a8)
(cherry picked from commit 1d52ff0)
(cherry picked from commit 2c3c172)
@IgorGanapolsky IgorGanapolsky enabled auto-merge (squash) March 31, 2026 18:59
@gemini-code-assist
Copy link
Copy Markdown

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

@sonarqubecloud
Copy link
Copy Markdown

Comment on lines +973 to 977
die(
"Could not enumerate subscriptions before App Review submission: "
f"{e}. Reference: {SUBSCRIPTION_REVIEW_DOC_URL}"
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The exception handling for subscription enumeration was changed from a soft warning to a hard failure using die(), causing transient API errors to abort the entire app submission.
Severity: MEDIUM

Suggested Fix

Revert the error handling to be more resilient. Instead of calling die(), log a warning and allow the function to return, similar to the previous implementation. This prevents transient API errors from aborting the entire submission process. Alternatively, implement a retry mechanism for the API call.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: scripts/asc_submit_for_review.py#L973-L977

Potential issue: In the `_ensure_subscription_review_state` function, any exception
caught during the enumeration of app subscriptions now triggers a call to `die()`, which
raises a `SystemExit`. This is a regression from the previous behavior, which would log
a warning and continue. As a result, transient issues like network timeouts, rate
limiting, or temporary App Store Connect API outages will now cause the entire iOS app
submission process to abort, making the deployment pipeline less resilient.

Did we get this right? 👍 / 👎 to inform future reviews.

@github-actions github-actions bot added the pr-state:blocked One or more required CI checks are failing label Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CI Some checks failed

Check Result
Android Tests success
iOS Build & Tests success
Python Unit Tests success
Python Script Tests + Release Gate success
Playwright Local Checks success
Security failure

View details

@IgorGanapolsky
Copy link
Copy Markdown
Owner Author

Superseded by later App Store submission fixes and the verified v1.3.17 release path. Closing this stale v1.3.15 hotfix PR.

auto-merge was automatically disabled April 6, 2026 18:11

Pull request was closed

@IgorGanapolsky IgorGanapolsky deleted the hotfix/v1.3.15-submission-fix branch April 6, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-state:blocked One or more required CI checks are failing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant