[codex] Add Android App Functions timer controls#1072
Closed
IgorGanapolsky wants to merge 4 commits intodevelopfrom
Closed
[codex] Add Android App Functions timer controls#1072IgorGanapolsky wants to merge 4 commits intodevelopfrom
IgorGanapolsky wants to merge 4 commits intodevelopfrom
Conversation
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
|
✅ CI All checks passed
|
Contributor
|
Contributor
|
✅ CI All checks passed
|
IgorGanapolsky
force-pushed
the
feat/android-appfunctions-v1
branch
from
33ceeba to
cd9bcf9
Compare
|
Contributor
|
✅ CI All checks passed
|
Owner
Author
|
Closing: superseded by later work or has unresolvable merge conflicts. Reopen if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
configureRandomTimer,startRandomTimer,pauseTimer,resumeTimer, andstopTimerRandomTimerAppintoAppFunctionConfiguration.Providerso Android 16+ callers can discover the app as a toolvoiceGendersurvives the foreground-service handoffcompileSdk 36, AGP8.9.1, Gradle8.11.1, KSP wiring, Android 36 SDK packages in Actions)Why
Android App Functions gives the app a higher-value Android entry path than launcher/deep-link only. This branch exposes the timer controls as callable Android 16+ functions while keeping the implementation on the existing timer stack.
Impact
voiceGenderwhen the timer starts through the service pathValidation
cd native-android && ANDROID_SDK_ROOT="$HOME/Library/Android/sdk" ANDROID_HOME="$HOME/Library/Android/sdk" ./gradlew :app:testDebugUnitTest :app:assembleDebug :app:lintDebugcd native-android && ANDROID_SDK_ROOT="$HOME/Library/Android/sdk" ANDROID_HOME="$HOME/Library/Android/sdk" ./gradlew :app:testDebugUnitTest --tests "com.iganapolsky.randomtimer.appfunctions.RandomTimerAppFunctionsE2ETest"app/build/generated/ksp/debug/resources/assets/Notes
RandomTimerAppFunctions: line100%, method100%, branch60.0%RandomTimerAppFunctionHandler: line100%, method100%, branch68.2%RandomTimerAppFunctionConfigFactory: line90.6%, method100%, branch90.0%TimerForegroundServiceKt: line100%, method100%