fix(audio): expand male voice preview from 3 to 10 samples#1034
Closed
IgorGanapolsky wants to merge 5 commits intodevelopfrom
Closed
fix(audio): expand male voice preview from 3 to 10 samples#1034IgorGanapolsky wants to merge 5 commits intodevelopfrom
IgorGanapolsky wants to merge 5 commits intodevelopfrom
Conversation
- Android: firebase-perf dependency, Performance Gradle plugin when Firebase is on - iOS: link FirebasePerformance SPM product, import in app entry - PostHog replay: fix Android config (debouncerDelayMs); align iOS with SDK (throttleDelay, no sampleRate) - Add docs/OBSERVABILITY.md (stack, privacy, gaps vs store-grade metrics) - SwiftLint: scoped disables and safer Apple Ads URLRequest Made-with: Cursor
Xcode references the plist for Crashlytics; the real file is gitignored. Generate a placeholder plist in the ios job so xcodebuild succeeds on runners. Made-with: Cursor
Scheme Test action passes -SkipFirebaseForTesting so hosted unit tests do not configure Firebase with CI placeholder plist (avoids SIGABRT). Made-with: Cursor
Scheme Test environment RT_SKIP_FIREBASE_FOR_TESTS is injected into the host app; CLI args alone were not applied on GitHub Actions. Mirror the env in the CI step as a fallback. Made-with: Cursor
Simulator-hosted tests do not receive shell or scheme env; pass OTHER_SWIFT_FLAGS=-D RT_SKIP_FIREBASE_FOR_CI on xcodebuild so init omits FirebaseApp.configure with the placeholder plist. Drop unused FirebasePerformance SPM link (no in-app API); Crashlytics remains. Made-with: Cursor
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
github-actions
Bot
added
the
pr-state:ci_running
|
Contributor
|
✅ CI All checks passed
|
Owner
Author
|
Closing: superseded by later work or has unresolvable merge conflicts. Reopen if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces repetition by adding 7 more marine callouts to the preview pool.