ci: add Trunk CI workflow (Check + Merge Queue + Flaky Tests)#1015
ci: add Trunk CI workflow (Check + Merge Queue + Flaky Tests)#1015IgorGanapolsky wants to merge 1 commit intodevelopfrom
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
|
| - name: Upload iOS Test Results | ||
| uses: trunk-io/analytics-uploader@main | ||
| with: | ||
| junit-paths: '**/build/reports/junit/*.xml,**/*.xcresult/**/*.xml' |
There was a problem hiding this comment.
Bug: The iOS test results upload step is misconfigured. It uses junit-paths to look for XML files, but the CI generates binary .xcresult bundles, causing the upload to silently fail.
Severity: MEDIUM
Suggested Fix
Replace the junit-paths parameter with xcresult-path and point it to the .xcresult bundle generated by the test step. This aligns the uploader with the actual artifact being produced, allowing it to process the binary test results directly.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/trunk.yml#L63
Potential issue: The "Upload iOS Test Results" step in the `trunk.yml` workflow is
configured to use the `junit-paths` parameter, which expects JUnit XML files. However,
the CI process generates a binary `.xcresult` bundle. The glob pattern
`**/*.xcresult/**/*.xml` will never match any files because `.xcresult` bundles are a
binary format and do not contain XML files directly. The workflow is missing a
conversion step (e.g., using `xcpretty`) to create JUnit XML. Because
`continue-on-error: true` is enabled, this step will silently fail without uploading any
iOS test data, defeating the purpose of the flaky test detection feature for iOS.
Did we get this right? 👍 / 👎 to inform future reviews.
|
❌ CI Some checks failed
|
|
Closing: superseded by later work or has unresolvable merge conflicts. Reopen if still needed. |


What
Adds
.github/workflows/trunk.ymlto integrate Trunk into the CI pipeline forRandom-Timer.Why
Completes Step 5 of the Trunk onboarding checklist:
merge_grouptrigger enables the Trunk Merge Queue to validate batched PRs before they land ondevelopRequired Action Before Merging
Checklist
trunk-io/trunk-action@v1runs onpull_request+push+merge_groupTRUNK_TOKENsecret wired in (must be added manually)continue-on-error: trueon upload steps so test failures don't block CIorg-slug: igor-personalmatches Trunk dashboard org