Skip to content

fix(validator): fix validator theme deriving input theme values #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rkaraivanov merged 6 commits into from
Jan 21, 2026
Merged

fix(validator): fix validator theme deriving input theme values #2063

rkaraivanov merged 6 commits into from
Jan 21, 2026

Conversation

@didimmova
Copy link
Contributor

@didimmova didimmova commented Jan 20, 2026

Closes #2057

@didimmova didimmova requested a review from desig9stein January 20, 2026 08:18
@rkaraivanov
Copy link
Member

rkaraivanov commented Jan 20, 2026

@didimmova
image

A question for the Bootstrap dark variant, are the colors of the label(s) and the invalid slot text supposed to differ?

@didimmova
Copy link
Contributor Author

didimmova commented Jan 20, 2026 •
edited
Loading

@didimmova image

A question for the Bootstrap dark variant, are the colors of the label(s) and the invalid slot text supposed to differ?

this is something the design team should decide @sdimchevski and will be fixed in the igniteui-theming repo later if necessary

@didimmova didimmova changed the title fix(validator): use map.get instead of var-get to access input-theme props fix(validator): fix validator theme deriving input theme values Jan 20, 2026
@rkaraivanov rkaraivanov merged commit f7cdbc4 into master Jan 21, 2026
7 checks passed
@rkaraivanov rkaraivanov deleted the didimmova/fix-validator-retrieving-values branch January 21, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desig9stein desig9stein desig9stein approved these changes

Assignees

@adrianptrv adrianptrv

Labels

validation ✅ status: verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Slotted validation text does not conform to the theme colors

6 participants

@didimmova @rkaraivanov @desig9stein @adrianptrv @simeonoff