Conversation
There was a problem hiding this comment.
Pull request overview
This PR moves the Angular test environment teardown configuration from a global test.ts file to individual chart component test files and fixes a typo in the linear gauge component name.
Changes:
- Removed the global test.ts file that configured teardown behavior for all tests
- Added chart-specific teardown configuration to financial-chart and category-chart test files
- Fixed typo in linear-gauge spec file where component name was missing the final 't'
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/igx-templates/igx-ts/projects/_base/files/src/test.ts | Deleted global test configuration file |
| packages/igx-templates/igx-ts/linear-gauge/default/files/src/app/path/filePrefix.component.spec.ts | Fixed typo in component name from "Componen" to "Component" |
| packages/igx-templates/igx-ts/financial-chart/default/files/src/app/path/filePrefix.component.spec.ts | Added teardown configuration to TestBed setup |
| packages/igx-templates/igx-ts/category-chart/default/files/src/app/path/filePrefix.component.spec.ts | Added teardown configuration to TestBed setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...lates/igx-ts/financial-chart/default/files/src/app/__path__/__filePrefix__.component.spec.ts
Show resolved
Hide resolved
...plates/igx-ts/category-chart/default/files/src/app/__path__/__filePrefix__.component.spec.ts
Show resolved
Hide resolved
|
The spec.ts tests are failing with errors like: |
This should be fixed now. We are providing the zone.js/testing in angular setup. |
Closes #1481.
Move the teardown logic to chart specific test and remove the test.ts file as not needed anymore. Also fix a typo in linear gauge spec file.