fix(skills): omit column widths by default in generated grid code#17324
Open
onlyexeption wants to merge 1 commit into
Open
fix(skills): omit column widths by default in generated grid code#17324onlyexeption wants to merge 1 commit into
onlyexeption wants to merge 1 commit into
Conversation
(cherry picked from commit fd1dbfac8ea7530f39e205a718362309562e5ad5)
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Ignite UI Angular grid skills reference docs to guide generated grid code toward omitting per-column width by default, allowing columns to auto-distribute available space unless the user explicitly requests fixed sizing (addresses the issue about unnecessary default column widths in generated code).
Changes:
- Clarifies the
widthinput description forigx-grid-lite-columnto recommend omitting it by default. - Adds explicit “omit
widthby default” guidance to the key rules in both standard grid (<igx-column>) and Grid Lite (<igx-grid-lite-column>) reference docs. - Adds sizing guidance explaining why fixed pixel widths can lead to unused/empty space and when
widthshould be set.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
skills/igniteui-angular-grids/references/types.md |
Updates Grid Lite column width guidance and adds a key rule to omit width by default for generated Grid Lite columns. |
skills/igniteui-angular-grids/references/structure.md |
Adds a key rule instructing generated <igx-column> elements to omit width unless explicitly requested. |
skills/igniteui-angular-grids/references/sizing.md |
Adds a sizing rule explaining the effects of omitting width vs. using fixed pixel widths and when to set width. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1696
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)