feat(lint): making unused vars an error and fixing lint

.mcp.json

@@ -0,0 +1,8 @@
+{
+  "servers": {
+    "angular-cli": {
+      "command": "npx",
+      "args": ["-y", "@angular/cli", "mcp"]
+    }
+  }
+}

eslint.config.mjs

@@ -45,7 +45,7 @@ export default [{
         "@typescript-eslint/no-shadow": "error",
         "no-unused-vars": "off",
 
-        "@typescript-eslint/no-unused-vars": ["warn", {
+        "@typescript-eslint/no-unused-vars": ["error", {
             args: "all",
             argsIgnorePattern: "^_",
             caughtErrors: "all",

projects/igniteui-angular-i18n/src/i18n/CS/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsCS as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/DA/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsDA as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/DE/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsDE as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/ES/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsES as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/FR/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsFR as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/HU/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsHU as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/IT/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsIT as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/JA/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsJA as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/KO/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsKO as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/NB/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsNB as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/NL/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsNL as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/PL/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsPL as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/PT/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsPT as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/RO/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsRO as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/SV/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsSV as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/TR/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsTR as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/ZH-HANS/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsZHHANS as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular-i18n/src/i18n/ZH-HANT/action-strip-resources.ts

@@ -1,4 +1,3 @@
-import { IActionStripResourceStrings } from 'igniteui-angular';
 import { IGX_PREFIX, prefixResource } from 'igniteui-i18n-core';
 import { ActionStripResourceStringsZHHANT as AActionStripResourceStrings } from 'igniteui-i18n-resources';
 

projects/igniteui-angular/button-group/src/button-group/button-group.component.ts

@@ -134,7 +134,7 @@ export class IgxButtonGroupComponent implements AfterViewInit, OnDestroy {
     }
     public set selectionMode(selectionMode: 'single' | 'singleRequired' | 'multi') {
         if (this.viewButtons && selectionMode !== this._selectionMode) {
-            this.buttons.forEach((b,i) => {
+            this.buttons.forEach((_b, i) => {
                 this.deselectButton(i);
             });
             this._selectionMode = selectionMode;

projects/igniteui-angular/carousel/src/carousel/carousel.component.ts

@@ -1057,7 +1057,7 @@ export class IgxCarouselComponent extends IgxCarouselComponentBase implements On
     private initSlides(change: QueryList<IgxSlideComponent>) {
         const diff = this.differ.diff(change.toArray());
         if (diff) {
-            this.slides.reduce((any, c, ind) => c.index = ind, 0); // reset slides indexes
+            this.slides.reduce((_any, c, ind) => c.index = ind, 0); // reset slides indexes
             diff.forEachAddedItem((record: IterableChangeRecord<IgxSlideComponent>) => {
                 const slide = record.item;
                 slide.total = this.total;

projects/igniteui-angular/chat/src/chat.component.ts

@@ -285,6 +285,7 @@ export interface ChatInputContext {
 @Directive({ selector: '[igxChatMessageContext]', standalone: true })
 export class IgxChatMessageContextDirective {
 
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     public static ngTemplateContextGuard(_: IgxChatMessageContextDirective, ctx: unknown): ctx is { $implicit: IgcChatMessage } {
         return true;
     }
@@ -304,6 +305,7 @@ export class IgxChatMessageContextDirective {
 @Directive({ selector: '[igxChatAttachmentContext]', standalone: true })
 export class IgxChatAttachmentContextDirective {
 
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     public static ngTemplateContextGuard(_: IgxChatAttachmentContextDirective, ctx: unknown): ctx is { $implicit: IgcChatMessageAttachment } {
         return true;
     }
@@ -323,6 +325,7 @@ export class IgxChatAttachmentContextDirective {
 @Directive({ selector: '[igxChatInputContext]', standalone: true })
 export class IgxChatInputContextDirective {
 
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     public static ngTemplateContextGuard(_: IgxChatInputContextDirective, ctx: unknown): ctx is ChatInputContext {
         return true;
     }

projects/igniteui-angular/core/src/core/styles/components/combo/_combo-theme.scss

@@ -167,7 +167,7 @@
             }
 
             .igx-input-group__bundle:hover::after {
-                border-block-end-color: #{if($variant == 'fluent', var(--hover-border-color), var(--border-color))};;
+                border-block-end-color: #{if($variant == 'fluent', var(--hover-border-color), var(--border-color))};
             }
 
             .igx-input-group--focused .igx-input-group__bundle::after {

projects/igniteui-angular/core/src/core/styles/components/grid/_grid-theme.scss

@@ -1187,7 +1187,7 @@
         }
 
         igx-icon {
-            --component-size: #{if($variant == 'indigo', 2, 3)};;
+            --component-size: #{if($variant == 'indigo', 2, 3)};
         }
     }
 
@@ -2623,7 +2623,7 @@
         }
 
         igx-icon {
-            --component-size: #{if($variant == 'indigo', 2, 3)};;
+            --component-size: #{if($variant == 'indigo', 2, 3)};
 
             color: var-get($theme, 'expand-icon-color');
             max-width: $hierarchical-action-icon;

projects/igniteui-angular/core/src/core/styles/components/query-builder/_query-builder-component.scss

@@ -145,7 +145,7 @@
         }
 
         @include e(details-button) {
-            @extend %filter-tree-details-button !optional;;
+            @extend %filter-tree-details-button !optional;
         }
     }
 }
@@ -162,6 +162,6 @@
 
 @mixin _query-builder-dialog {
     @include b(igx-query-builder-dialog) {
-        @extend %query-builder-dialog !optional;;
+        @extend %query-builder-dialog !optional;
     }
 }

projects/igniteui-angular/core/src/core/utils.ts

@@ -100,7 +100,8 @@ export const copyDescriptors = (obj) => {
  */
 export const mergeObjects = (obj1: any, obj2: any): any => mergeWith(obj1, obj2, (objValue, srcValue) => {
     if (Array.isArray(srcValue)) {
-        return objValue = srcValue;
+        objValue = srcValue;
+        return objValue;
     }
 });
 

projects/igniteui-angular/core/src/data-operations/expressions-tree-util.spec.ts

@@ -1,6 +1,6 @@
 import { FilteringLogic, IFilteringExpression } from './filtering-expression.interface';
 import { FilteringExpressionsTree, IFilteringExpressionsTree } from './filtering-expressions-tree';
-import { recreateExpression, recreateTree, recreateTreeFromFields } from './expressions-tree-util';
+import { recreateTree, recreateTreeFromFields } from './expressions-tree-util';
 import { IgxBooleanFilteringOperand, IgxDateFilteringOperand, IgxDateTimeFilteringOperand, IgxNumberFilteringOperand, IgxStringFilteringOperand, IgxTimeFilteringOperand } from './filtering-condition';
 import type { EntityType, FieldType } from './grid-types';
 

projects/igniteui-angular/core/src/data-operations/test-util/data-generator.ts

@@ -31,7 +31,7 @@ export class DataGenerator {
     public generateArray(startValue, endValue) {
         const len = Math.abs(startValue - endValue);
         const decrement = startValue > endValue;
-        return Array.from({ length: len + 1 }, (e, i) => decrement ? startValue - i : startValue + i);
+        return Array.from({ length: len + 1 }, (_e, i) => decrement ? startValue - i : startValue + i);
     }
     public getValuesForColumn(data, fieldName) {
         return data.map((x) => x[fieldName]);

projects/igniteui-angular/core/src/services/overlay/position/base-fit-position-strategy.ts

@@ -18,7 +18,7 @@ export abstract class BaseFitPositionStrategy extends ConnectedPositioningStrate
      * ```
      */
     public override position(
-        contentElement: HTMLElement, size: Size, document?: Document, initialCall?: boolean, target?: Point | HTMLElement): void {
+        contentElement: HTMLElement, _size: Size, document?: Document, initialCall?: boolean, target?: Point | HTMLElement): void {
         const rects = super.calculateElementRectangles(contentElement, target);
         const connectedFit: ConnectedFit = {};
         if (initialCall) {

projects/igniteui-angular/core/src/services/overlay/position/connected-positioning-strategy.ts

@@ -46,7 +46,7 @@ export class ConnectedPositioningStrategy implements IPositionStrategy {
    * settings.positionStrategy.position(content, size, document, true);
    * ```
    */
-  public position(contentElement: HTMLElement, size: Size, document?: Document, initialCall?: boolean, target?: Point | HTMLElement): void {
+  public position(contentElement: HTMLElement, _size: Size, _document?: Document, _initialCall?: boolean, target?: Point | HTMLElement): void {
     const rects = this.calculateElementRectangles(contentElement, target);
     this.setStyle(contentElement, rects.targetRect, rects.elementRect, {});
   }

projects/igniteui-angular/core/src/services/theme/theme.token.ts

@@ -37,6 +37,7 @@ export const THEME_TOKEN = new InjectionToken<ThemeToken>('ThemeToken', {
     factory: () => new ThemeToken()
 });
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 const Theme = {
     Material: "material",
     Fluent: "fluent",

projects/igniteui-angular/date-picker/src/date-picker/date-picker.component.ts

@@ -62,7 +62,6 @@ import {
     DatePartDeltas,
     DatePart,
     isDateInRanges,
-    IgxOverlayOutletDirective,
     I18N_FORMATTER
 } from 'igniteui-angular/core';
 import { IDatePickerValidationFailedEventArgs } from './date-picker.common';

projects/igniteui-angular/date-picker/src/date-range-picker/date-range-picker.component.ts

@@ -1,5 +1,5 @@
 import {
-    AfterViewInit, booleanAttribute, ChangeDetectorRef, Component, ContentChild, ContentChildren, ElementRef,
+    AfterViewInit, booleanAttribute, ChangeDetectorRef, Component, ContentChild, ContentChildren,
     EventEmitter, HostBinding, HostListener, Injector, Input,
     OnChanges, OnDestroy, OnInit, Output, QueryList,
     SimpleChanges, TemplateRef, ViewChild, ViewContainerRef, inject

projects/igniteui-angular/date-picker/src/date-range-picker/predefined-ranges/predefined-ranges-area.component.ts

@@ -30,7 +30,7 @@ export class IgxPredefinedRangesAreaComponent {
         return [...base, ...(this.customRanges ?? [])];
     }
 
-    public trackByLabel = (i: number, r: CustomDateRange) => r.label;
+    public trackByLabel = (_i: number, r: CustomDateRange) => r.label;
 
     public onSelect(range: DateRange) {
         this.rangeSelect.emit(range);

projects/igniteui-angular/directives/src/directives/for-of/base.helper.component.ts

@@ -1,5 +1,4 @@
 import {
-    HostListener,
     ElementRef,
     ChangeDetectorRef,
     OnDestroy,

projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.ts

@@ -556,7 +556,8 @@ export class IgxForOfDirective<T, U extends T[] = T[]> extends IgxForOfToken<T,U
      * The presence of this method is a signal to the Ivy template type-check compiler that the
      * `IgxForOf` structural directive renders its template with a specific context type.
      */
-    public static ngTemplateContextGuard<T, U extends T[]>(dir: IgxForOfDirective<T, U>, ctx: any):
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    public static ngTemplateContextGuard<T, U extends T[]>(_dir: IgxForOfDirective<T, U>, ctx: any):
         ctx is IgxForOfContext<T, U> {
         return true;
     }
@@ -571,7 +572,7 @@ export class IgxForOfDirective<T, U extends T[] = T[]> extends IgxForOfToken<T,U
             if (!this._differ && value) {
                 try {
                     this._differ = this._differs.find(value).create(this.igxForTrackBy);
-                } catch (e) {
+                } catch (_e) {
                     throw new Error(
                         `Cannot find a differ supporting object "${value}" of type "${getTypeNameForDebugging(value)}".
                      NgFor only supports binding to Iterables such as Arrays.`);
@@ -1529,7 +1530,7 @@ export class IgxForOfDirective<T, U extends T[] = T[]> extends IgxForOfToken<T,U
 
     protected _updateScrollOffset() {
         let scrollOffset = 0;
-        let currentScroll = this.scrollPosition;
+        const currentScroll = this.scrollPosition;
         if (this._virtRatio !== 1) {
             this._calcVirtualScrollPosition(this.scrollPosition);
             scrollOffset = this.fixedUpdateAllElements(this._virtScrollPosition);
@@ -1666,7 +1667,8 @@ export class IgxGridForOfDirective<T, U extends T[] = T[]> extends IgxForOfDirec
      * The presence of this method is a signal to the Ivy template type-check compiler that the
      * `IgxGridForOfDirective` structural directive renders its template with a specific context type.
      */
-    public static override ngTemplateContextGuard<T, U extends T[]>(dir: IgxGridForOfDirective<T, U>, ctx: any):
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    public static override ngTemplateContextGuard<T, U extends T[]>(_dir: IgxGridForOfDirective<T, U>, ctx: any):
         ctx is IgxGridForOfContext<T, U> {
         return true;
     }
@@ -1695,7 +1697,7 @@ export class IgxGridForOfDirective<T, U extends T[] = T[]> extends IgxForOfDirec
             if (!this._differ && value) {
                 try {
                     this._differ = this._differs.find(value).create(this.igxForTrackBy);
-                } catch (e) {
+                } catch (_e) {
                     throw new Error(
                         `Cannot find a differ supporting object "${value}" of type "${getTypeNameForDebugging(value)}".
                      NgFor only supports binding to Iterables such as Arrays.`);

projects/igniteui-angular/drop-down/src/drop-down/drop-down.component.spec.ts

@@ -1612,7 +1612,7 @@ class VirtualizedDropDownComponent {
     public itemsMaxHeight = 400;
     public itemHeight = 40;
     constructor() {
-        this.items = Array.apply(null, { length: 2000 }).map((e, i) => ({
+        this.items = Array.apply(null, { length: 2000 }).map((_e, i) => ({
             name: `Item ${i + 1}`,
             id: i
         }));

projects/igniteui-angular/grids/core/src/api.service.ts

@@ -630,7 +630,7 @@ export class GridBaseAPIService<T extends GridType> implements GridServiceType {
     }
 
 
-    protected update_row_in_array(value: any, rowID: any, index: number) {
+    protected update_row_in_array(value: any, _rowID: any, index: number) {
         const grid = this.grid;
         grid.data[index] = value;
     }