fix(date-picker): fix discrepencies in datepicker#17282
Open
didimmova wants to merge 2 commits into
Open
Conversation
didimmova
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Date Range Picker sizing/styling discrepancies by adjusting dialog action spacing and enabling Indigo-specific action button variants.
Changes:
- Adds theme-aware Indigo dialog button variants for Date Range Picker actions.
- Makes calendar container action button types configurable.
- Replaces inner button padding with an 8px gap to avoid double-padding in picker footers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
projects/igniteui-angular/date-picker/src/date-range-picker/date-range-picker.component.ts |
Sets Indigo dialog action buttons to contained/outlined variants. |
projects/igniteui-angular/date-picker/src/date-picker/calendar-container/calendar-container.component.ts |
Adds configurable button type properties for close/cancel actions. |
projects/igniteui-angular/date-picker/src/date-picker/calendar-container/calendar-container.component.html |
Binds close/cancel buttons to configurable IgxButton types. |
projects/igniteui-angular/core/src/core/styles/components/date-picker/_date-picker-theme.scss |
Updates footer button spacing to use an 8px gap instead of inner padding. |
Comment on lines
+1343
to
+1345
| if (!this.isDropdown && this.themeToken.theme === 'indigo') { | ||
| componentInstance.closeButtonType = 'contained'; | ||
| componentInstance.cancelButtonType = 'outlined'; |
Contributor
Author
There was a problem hiding this comment.
I set the default button types to 'flat' and the change is only applicable for indigo date-range-picker in dialog mode, so maybe the additional checks are not necessary, also the spec files are written only for the material theme, so we don't need tests for the indigo button types
| <button | ||
| #cancelButton type="button" | ||
| igxButton="flat" igxRipple | ||
| [igxButton]="cancelButtonType" igxRipple |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16741