Skip to content

Do not reposition detached overlay#16998

Merged
wnvko merged 5 commits intomasterfrom
mvenkov/do-not-update-position-when-outlet-is-detached
Mar 10, 2026
Merged

Do not reposition detached overlay#16998
wnvko merged 5 commits intomasterfrom
mvenkov/do-not-update-position-when-outlet-is-detached

Conversation

@wnvko
Copy link
Contributor

@wnvko wnvko commented Mar 6, 2026

Closes #16988
When trying to reposition the wrapper element check if it is not already detached.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@wnvko wnvko added ❌ status: awaiting-test PRs awaiting manual verification overlay version: 21.1.x labels Mar 6, 2026
@wnvko wnvko requested review from Hristo313 and mtsvyatkova March 6, 2026 09:37
@mtsvyatkova mtsvyatkova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 9, 2026
@wnvko wnvko merged commit 28ad300 into master Mar 10, 2026
5 checks passed
@wnvko wnvko deleted the mvenkov/do-not-update-position-when-outlet-is-detached branch March 10, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

overlay version: 21.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ContainerPositionStrategy.updatePosition crashes when content element is detached from DOM

3 participants