fix(grid-pinning): remove hide call in scrollToRow - master#16784
fix(grid-pinning): remove hide call in scrollToRow - master#16784IMinchev64 wants to merge 8 commits intomasterfrom
Conversation
|
@skrustev @IMinchev64 The change is fine. However, if the action strip is set as menu this behavior is not perfect IMO. |
|
@mddragnev I added a condition to continue hiding the strip when the action strip is a menu. Note that testing this in elements would be a bit of a hassle currently as:
|
|
The issue still reproduces when the record you try to scroll to is out of view |
I am failing to reproduce this scenario with the same result |
|
Replaced the unconditional action-strip hide/reset on vertical scroll with a conditional check: keep it only when the current context row is pinned, still connected to the DOM, and hovered; otherwise keep the previous hide + context reset behavior. This preserves virtualization cleanup while preventing the strip from disappearing during pinned-row jump/scroll scenarios. |
There was a problem hiding this comment.
Pull request overview
Fixes a regression where the grid Action Strip closes when using the row-pinning “jump” action (scroll), especially for pinned rows.
Changes:
- Update grid vertical scroll handling to avoid hiding the Action Strip when scrolling a hovered pinned row.
- Update the pinning actions “scrollToRow” behavior to only auto-hide the Action Strip when the actions are rendered as menu items.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/grid/src/grid-base.directive.ts | Keeps the Action Strip visible during vertical scroll when the current context is a hovered pinned row. |
| projects/igniteui-angular/grids/core/src/grid-actions/grid-pinning-actions.component.ts | Prevents auto-hiding the Action Strip on “jump” in button mode; preserves menu behavior. |
projects/igniteui-angular/grids/core/src/grid-actions/grid-pinning-actions.component.ts
Show resolved
Hide resolved
|
@IMinchev64 please click on resolve conversation button if the review comments are ready. |
Closes #16493
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)