Skip to content

fix(treeGrid): Fix expansion state returning 0 instead of false in some cases. #16716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skrustev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(treeGrid): Fix expansion state returning 0 instead of false in some cases. #16716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/igniteui-angular/grids/tree-grid/src/tree-grid-api.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class IgxTreeGridAPIService extends GridBaseAPIService<GridType> {
if (expanded !== undefined) {
return expanded;
} else {
return record.children && record.children.length && record.level < grid.expansionDepth;
return record.children && !!record.children.length && record.level < grid.expansionDepth;
}
}

Expand Down
9 changes: 9 additions & 0 deletions projects/igniteui-angular/grids/tree-grid/src/tree-grid-expanding.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ describe('IgxTreeGrid - Expanding / Collapsing #tGrid', () => {
treeGrid = fix.componentInstance.treeGrid;
});

it('should return boolean for expand state of row without children using getRowByKey()', () => {
treeGrid.primaryKey = "ID";
treeGrid.childDataKey = "";
fix.detectChanges();

const testRow = treeGrid.getRowByKey(147);
expect(testRow.expanded).toEqual(false);
});

it('check row expanding and collapsing are changing rows count (UI)', () => {
let rows = TreeGridFunctions.getAllRows(fix);
expect(rows.length).toBe(4);
Expand Down
Loading