[WIP] Re-add React\Promise\ExtendedPromiseInterface for its existing users#90
Closed
Al2Klimov wants to merge 12 commits intotest/php-85from
Closed
[WIP] Re-add React\Promise\ExtendedPromiseInterface for its existing users#90Al2Klimov wants to merge 12 commits intotest/php-85from
Al2Klimov wants to merge 12 commits intotest/php-85from
Conversation
- Add additional patch for still missing non canonical cast from (Shardj/zf1-future#509) - Remove patch to see if it is still required or not
- It is required for x509 module
- Cannot install `react/http` (used in notifications module) otherwise, because it requires psr/http-message:^1.0
- It is used in notifications module
The patch has been merged to master.
as an alias for its base interface, PromiseInterface. Now our code works with the latest React\Promise and has time to switch to PromiseInterface.
Al2Klimov
commented
Jan 19, 2026
Member
Author
Al2Klimov
left a comment
Al2Klimov
left a comment
There was a problem hiding this comment.
Test
(new ReflectionClass(ExtendedPromiseInterface::class))->getFileName()
Before
Class "React\Promise\ExtendedPromiseInterface" does not exist
After
/nix/store/dh4p4c5mwad7ccivmfy2fhbd9hr12hr9-icingaweb2-thirdparty-0.13.1/vendor/react/promise/src/PromiseInterface.php
Member
Author
|
The catch is, I had to remove vendor/react/promise/, React\Promise v2, from icinga-php-library. On my machine, ipl wins against thirdparty during autoloading. |
sukhwinder33445
force-pushed
the
test/php-85
branch
5 times, most recently
from
7ef92cd to
911f231
Compare
lippserd
force-pushed
the
test/php-85
branch
2 times, most recently
from
9a12a41 to
9a0f8ba
Compare
Member
|
Justification for closing this PR: Icinga/ipl-scheduler#61 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as an alias for its base interface, PromiseInterface.
Now our code works with the latest React\Promise and has time to switch to PromiseInterface.
This PR is based on f4e7375 which is 1 commit behind #82's c5f5889. The latter downgrades React\Promise which is explicitly not desired for my solution here.
TODO