Skip to content

Add Kafka Diagnostics IOC#1

Merged
rerpha merged 26 commits intomainfrom
kdae_diag
Apr 27, 2026
Merged

Add Kafka Diagnostics IOC#1
rerpha merged 26 commits intomainfrom
kdae_diag

Conversation

@Tom-Willemsen
Copy link
Copy Markdown
Member

@Tom-Willemsen Tom-Willemsen commented Jan 8, 2026 •
edited
Loading

@Tom-Willemsen Tom-Willemsen added the Semver-Major Changes to existing functionality requiring changes in user code label Jan 8, 2026
@Tom-Willemsen Tom-Willemsen force-pushed the kdae_diag branch 9 times, most recently from 86b5b26 to 006b8b0 Compare January 18, 2026 14:17
@Tom-Willemsen Tom-Willemsen marked this pull request as ready for review February 18, 2026 13:18
@Tom-Willemsen Tom-Willemsen mentioned this pull request Feb 18, 2026
Closed
rerpha
rerpha reviewed Mar 9, 2026
View reviewed changes
Comment thread src/kafka_dae_diagnostics/_cli.py Outdated
@Tom-Willemsen Tom-Willemsen force-pushed the kdae_diag branch 2 times, most recently from d3caff1 to 540c3e1 Compare March 20, 2026 15:51
rerpha
rerpha reviewed Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rerpha rerpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial comments

Comment thread src/kafka_dae_diagnostics/_cli.py Outdated
Comment thread config_example.toml
Comment thread src/kafka_dae_diagnostics/serve.py
]

server = Server(providers=providers)
with server:
Copy link
Copy Markdown
Contributor

@rerpha rerpha Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this process will likely need to bind to a PVAS interface, should we check in os.environ for EPICS_PVAS_INTF_ADDRESS_LIST and fail if it isn't set?

Copy link
Copy Markdown
Member Author

@Tom-Willemsen Tom-Willemsen Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure about hard-failing, but have added an explicit warning message for this case.

Comment thread doc/pydantic.inv
rerpha
rerpha reviewed Apr 24, 2026
View reviewed changes
Comment thread src/kafka_dae_diagnostics/kafka/handlers.py Outdated
rerpha
rerpha reviewed Apr 24, 2026
View reviewed changes
Comment thread src/kafka_dae_diagnostics/kafka/handlers.py Outdated
@Tom-Willemsen Tom-Willemsen requested a review from rerpha April 27, 2026 13:30
@rerpha rerpha merged commit 6918329 into main Apr 27, 2026
11 checks passed
@rerpha rerpha deleted the kdae_diag branch April 28, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rerpha rerpha rerpha approved these changes

Assignees

No one assigned

Labels

Semver-Major Changes to existing functionality requiring changes in user code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

prototype a process which serves spectra plots over EPICS (kafka_dae_diagnostics) TIMEBOX [1 week]

2 participants

@Tom-Willemsen @rerpha