-
Notifications
You must be signed in to change notification settings - Fork 2
correct ansible docs and make clear that playbook needs to be run bef… #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| ## Preparatory Steps for Client and Server | ||
|
|
||
| Before starting any manual deployments, run the [`instrument_deploy.yaml` ansible playbook](https://github.com/ISISComputingGroup/ansible-playbooks/tree/main?tab=readme-ov-file#instrument_deployyaml) which currently installs the JDK on instruments. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do you run this and if ndx do you need to install ansible first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you run this on your own computer just for the ndx you intend to target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You run it in your own WSL instance which has SSH key-based access to the instruments - i can add some notes to https://github.com/ISISComputingGroup/ansible-playbooks?tab=readme-ov-file#ansible-ndx to make this clearer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think adding an example shownig use of --limit for a deploy would be helpful so we don't have multiple people accidentally deploying to e.g. all of ts1 at the same time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think adding an example shownig use of
--limitfor a deploy would be helpful so we don't have multiple people accidentally deploying to e.g. all of ts1 at the same time
it prompts for this when you run it so you don't accidentally run it everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have also added note in a0a32d0
…ore deploys