Skip to content

Fix cyclic dependencies and header cleanup#511

Open
simon-schlepphorst wants to merge 6 commits into
IPPL-framework:masterfrom
simon-schlepphorst:fix/507_cyclic_dependencies
Open

Fix cyclic dependencies and header cleanup#511
simon-schlepphorst wants to merge 6 commits into
IPPL-framework:masterfrom
simon-schlepphorst:fix/507_cyclic_dependencies

Conversation

@simon-schlepphorst

Copy link
Copy Markdown
Contributor

Fixing #507.

Work in progress

@simon-schlepphorst simon-schlepphorst changed the title First fix for BareField, FieldLayout and SubFieldLayout Fix cyclic dependencies and header cleanup May 19, 2026
@aaadelmann aaadelmann self-requested a review May 19, 2026 13:47
@simon-schlepphorst

simon-schlepphorst commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

include-what-you-use instructions, example for src/Types/Vector.h:

MYFLAGS=<all flags from compile_commands.json>
cd build/
include-what-you-use -xc++ $MYFLAGS -DIPPL_VECTOR_HPP ../src/Types/Vector.h
  • -xc++: interpret *.h files as C++ header
  • -DIPPL_VECTOR_HPP: trigger the include guard to stop Vector.hpp to be appended at the bottom of Vector.h. Otherwise the output is cluttered with recommendations for Vector.hpp as well ...

@aaadelmann aaadelmann marked this pull request as ready for review May 21, 2026 14:45
@aaadelmann

Copy link
Copy Markdown
Member

cscs-ci run cscs-ci-gh200, cscs-ci-mi300, cscs-ci-openmp

@aaadelmann

aaadelmann commented May 21, 2026

Copy link
Copy Markdown
Member

cscs-ci run cscs-ci-gh200, cscs-ci-mi300, cscs-ci-openmp

@aaadelmann aaadelmann self-requested a review May 21, 2026 18:40
@aliemen

aliemen commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

cscs-ci run cscs-ci-mi300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants