feat: remove deprecated methods related to redirect uris #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we are not using those methods anymore since 1.3.0
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated utility methods sanitize_redirect_uris and get_redirect_uris that have been unused since version 1.3.0. The changes include removing the method implementations from the utils module, their associated test cases, and cleaning up now-unused imports.
- Removed two deprecated methods and their comprehensive test suite
- Cleaned up unused imports (
os,ast,re) - Updated CHANGES.md to document the removal
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/pas/plugins/kimug/utils.py | Removed deprecated sanitize_redirect_uris and get_redirect_uris methods and unused imports |
| tests/utils/test_utils.py | Removed test cases for the deprecated methods and cleaned up unused os import |
| src/pas/plugins/kimug/plugin/init.py | Removed unused os import |
| CHANGES.md | Added changelog entry documenting the removal of deprecated methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we are not using those methods anymore since 1.3.0