Skip to content

Conversation

@remdub
Copy link
Member

@remdub remdub commented Sep 25, 2025

No description provided.

@remdub remdub requested a review from Copilot September 25, 2025 07:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling in the OIDC settings configuration by adding graceful fallbacks when either the Plone site or OIDC plugin are unavailable, preventing crashes during initialization.

  • Added try-catch blocks to handle missing Plone site and OIDC plugin scenarios
  • Modified the control flow to skip OIDC configuration when dependencies are unavailable
  • Updated changelog to document the enhancement

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/pas/plugins/kimug/utils.py Added error handling for missing Plone site and OIDC plugin with early returns
CHANGES.md Added changelog entry documenting the new error handling behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@remdub remdub requested a review from bsuttor September 25, 2025 07:22
@bsuttor bsuttor merged commit bdc94b4 into main Sep 25, 2025
7 checks passed
@remdub remdub deleted the error_no_plone branch October 27, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants